From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPftu-0006UX-DA
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 11:25:58 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPfts-0006Tx-Qy
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 11:25:58 -0500
Received: from [199.232.76.173] (port=50937 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPfts-0006Tu-Nq
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 11:25:56 -0500
Received: from moutng.kundenserver.de ([212.227.126.171]:50887)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent@lvivier.info>) id 1LPfts-0008Lu-3K
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 11:25:56 -0500
Message-Id: <2199746.324571232555139352.JavaMail.servlet@kundenserver>
From: laurent@lvivier.info
Subject: Re: [Qemu-devel] [PATCH] Fix a compile error when none of the
	definesis hit
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Date: Wed, 21 Jan 2009 17:25:39 +0100
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: yu.liu@freescale.com

>Liu Yu wrote:
>> Signed-off-by: Liu Yu <yu.liu@freescale.com>
>>   
>
>What particularly circumstance would this be, --disable-sdl?
>
>> ---
>>  vl.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 63d954b..1bf13c0 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -5548,6 +5548,8 @@ int main(int argc, char **argv, char **envp)
>>                      sdl_display_init(ds, full_screen, no_frame);
>>  #elif defined(CONFIG_COCOA)
>>                      cocoa_display_init(ds, full_screen);
>> +#else
>> +		    ;
>>   
>
>I'd rather see something like do {} while (0); with a comment.

Or something like this ?

#if defined(CONFIG_SDL)
                if (sdl || !vnc_display)
                    sdl_display_init(ds, full_screen, no_frame);
#elif defined(CONFIG_COCOA)
                if (sdl || !vnc_display)
                    cocoa_display_init(ds, full_screen);
#endif

Laurent