Re: [Qemu-devel] [PATCH] Fix a compile error when none of the definesis hit

Re: [Qemu-devel] [PATCH] Fix a compile error when none of the definesis hit

[laurent]

>Liu Yu wrote:
>> Signed-off-by: Liu Yu <yu.liu@freescale.com>
>>   
>
>What particularly circumstance would this be, --disable-sdl?
>
>> ---
>>  vl.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 63d954b..1bf13c0 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -5548,6 +5548,8 @@ int main(int argc, char **argv, char **envp)
>>                      sdl_display_init(ds, full_screen, no_frame);
>>  #elif defined(CONFIG_COCOA)
>>                      cocoa_display_init(ds, full_screen);
>> +#else
>> +		    ;
>>   
>
>I'd rather see something like do {} while (0); with a comment.

Or something like this ?

#if defined(CONFIG_SDL)
                if (sdl || !vnc_display)
                    sdl_display_init(ds, full_screen, no_frame);
#elif defined(CONFIG_COCOA)
                if (sdl || !vnc_display)
                    cocoa_display_init(ds, full_screen);
#endif

Laurent

Re: [Qemu-devel] [PATCH] Fix a compile error when none of the definesis hit

[Ian Jackson]

laurent@lvivier.info writes ("Re: [Qemu-devel] [PATCH] Fix a compile error when none of the definesis hit"):
> [Anthony:]
> >I'd rather see something like do {} while (0); with a comment.

This is all rather mystifying to me.  What's wrong with just adding
braces ?

-               if (sdl || !vnc_display)
+               if (sdl || !vnc_display) {
  #if defined(CONFIG_SDL)
                    sdl_display_init(ds, full_screen, no_frame);
  #elif defined(CONFIG_COCOA)
                    cocoa_display_init(ds, full_screen);
  #endif
+               }

Ian.