qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Igor Mammedov <imammedo@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Shiju Jose <shiju.jose@huawei.com>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Ani Sinha <anisinha@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Shannon Zhao <shannon.zhaosl@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v7 14/19] arm/virt: Wire up a GED error device for ACPI / GHES
Date: Sun,  2 Mar 2025 09:22:01 +0100	[thread overview]
Message-ID: <219cf9c952b51fb26701e75ff39ef62faf6a2a24.1740903110.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1740903110.git.mchehab+huawei@kernel.org>

Adds support to ARM virtualization to allow handling
generic error ACPI Event via GED & error source device.

It is aligned with Linux Kernel patch:
https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.huang@intel.com/

Co-authored-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Co-authored-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Acked-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 hw/arm/virt-acpi-build.c |  1 +
 hw/arm/virt.c            | 12 +++++++++++-
 include/hw/arm/virt.h    |  1 +
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 5443615d976d..2bf9118fda55 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -861,6 +861,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
     }
 
     acpi_dsdt_add_power_button(scope);
+    aml_append(scope, aml_error_device());
 #ifdef CONFIG_TPM
     acpi_dsdt_add_tpm(scope, vms);
 #endif
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 4a5a9666e916..3faf32f900b5 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -678,7 +678,7 @@ static inline DeviceState *create_acpi_ged(VirtMachineState *vms)
     DeviceState *dev;
     MachineState *ms = MACHINE(vms);
     int irq = vms->irqmap[VIRT_ACPI_GED];
-    uint32_t event = ACPI_GED_PWR_DOWN_EVT;
+    uint32_t event = ACPI_GED_PWR_DOWN_EVT | ACPI_GED_ERROR_EVT;
 
     if (ms->ram_slots) {
         event |= ACPI_GED_MEM_HOTPLUG_EVT;
@@ -1010,6 +1010,13 @@ static void virt_powerdown_req(Notifier *n, void *opaque)
     }
 }
 
+static void virt_generic_error_req(Notifier *n, void *opaque)
+{
+    VirtMachineState *s = container_of(n, VirtMachineState, generic_error_notifier);
+
+    acpi_send_event(s->acpi_dev, ACPI_GENERIC_ERROR);
+}
+
 static void create_gpio_keys(char *fdt, DeviceState *pl061_dev,
                              uint32_t phandle)
 {
@@ -2404,6 +2411,9 @@ static void machvirt_init(MachineState *machine)
 
     if (has_ged && aarch64 && firmware_loaded && virt_is_acpi_enabled(vms)) {
         vms->acpi_dev = create_acpi_ged(vms);
+        vms->generic_error_notifier.notify = virt_generic_error_req;
+        notifier_list_add(&acpi_generic_error_notifiers,
+                          &vms->generic_error_notifier);
     } else {
         create_gpio_devices(vms, VIRT_GPIO, sysmem);
     }
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index c8e94e6aedc9..f3cf28436770 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -176,6 +176,7 @@ struct VirtMachineState {
     DeviceState *gic;
     DeviceState *acpi_dev;
     Notifier powerdown_notifier;
+    Notifier generic_error_notifier;
     PCIBus *bus;
     char *oem_id;
     char *oem_table_id;
-- 
2.48.1



  parent reply	other threads:[~2025-03-02  8:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-02  8:21 [PATCH v7 00/19] Change ghes to use HEST-based offsets and add support for error inject Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 01/19] tests/acpi: virt: add an empty HEST file Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 02/19] tests/qtest/bios-tables-test: extend to also check HEST table Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 03/19] tests/acpi: virt: update HEST file with its current data Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 04/19] acpi/ghes: Cleanup the code which gets ghes ged state Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 05/19] acpi/ghes: prepare to change the way HEST offsets are calculated Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 06/19] acpi/ghes: add a firmware file with HEST address Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 07/19] acpi/ghes: Use HEST table offsets when preparing GHES records Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 08/19] acpi/ghes: don't hard-code the number of sources for HEST table Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 09/19] acpi/ghes: add a notifier to notify when error data is ready Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 10/19] acpi/generic_event_device: Update GHES migration to cover hest addr Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 11/19] acpi/generic_event_device: add logic to detect if HEST addr is available Mauro Carvalho Chehab
2025-03-02  8:21 ` [PATCH v7 12/19] acpi/generic_event_device: add an APEI error device Mauro Carvalho Chehab
2025-03-02  8:22 ` [PATCH v7 13/19] tests/acpi: virt: allow acpi table changes at DSDT and HEST tables Mauro Carvalho Chehab
2025-03-02  8:22 ` Mauro Carvalho Chehab [this message]
2025-03-02  8:22 ` [PATCH v7 15/19] qapi/acpi-hest: add an interface to do generic CPER error injection Mauro Carvalho Chehab
2025-03-02  8:22 ` [PATCH v7 16/19] acpi/generic_event_device.c: enable use_hest_addr for QEMU 10.x Mauro Carvalho Chehab
2025-03-02  8:22 ` [PATCH v7 17/19] tests/acpi: virt: update HEST and DSDT tables Mauro Carvalho Chehab
2025-03-02  8:22 ` [PATCH v7 18/19] docs: hest: add new "etc/acpi_table_hest_addr" and update workflow Mauro Carvalho Chehab
2025-03-02  8:22 ` [PATCH v7 19/19] scripts/ghes_inject: add a script to generate GHES error inject Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=219cf9c952b51fb26701e75ff39ef62faf6a2a24.1740903110.git.mchehab+huawei@kernel.org \
    --to=mchehab+huawei@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhaosl@gmail.com \
    --cc=shiju.jose@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).