From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ikcot-00068Q-VG
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 05:46:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ikcoq-00066m-Tk
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 05:46:35 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ikcoq-00066c-ML
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 05:46:32 -0400
Received: from wr-out-0506.google.com ([64.233.184.228])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <ikalvachev@gmail.com>) id 1Ikcoq-0005UV-5I
	for qemu-devel@nongnu.org; Wed, 24 Oct 2007 05:46:32 -0400
Received: by wr-out-0506.google.com with SMTP id c38so275004wra
	for <qemu-devel@nongnu.org>; Wed, 24 Oct 2007 02:46:30 -0700 (PDT)
Message-ID: <219e947f0710240246w4532d346pce373fa62a17c77d@mail.gmail.com>
Date: Wed, 24 Oct 2007 12:46:26 +0300
From: "Ivan Kalvachev" <ikalvachev@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Physical hard disk drive for win32
In-Reply-To: <471CEB10.9030600@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <001d01c6df8e$2de302c0$0464a8c0@athlon>
	<7fac565a0609240214u5eca5cedka8a023ab562a87f7@mail.gmail.com>
	<002501c6dfd2$5e5ae820$0464a8c0@athlon>
	<47190FA7.80108@mail.berlios.de>
	<219e947f0710220433l1d652092kd238d6ccb8aeb95a@mail.gmail.com>
	<471CEB10.9030600@mail.berlios.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

2007/10/22, Stefan Weil <weil@mail.berlios.de>:
> Ivan Kalvachev schrieb:
> > According to http://msdn2.microsoft.com/en-us/library/aa365171.aspx
> >
> > this function requires Win XP or Vista.
> > Is qemu supported only on these?
> Good question. The old IOCTL_DISK_GET_DRIVE_GEOMETRY
> was also supported for W2K. Will QEMU support W2K as a host
> longer than MS does? It would make things easier if we
> dropped support for W2K hosts.
>
> If we need host support for W2K, I'll check another method
> to get the disk size (reading size of partition 0) and send
> a new patch. Please send your feedback in this case.
>
> I hope we don't need W95 or W98 host support!?

Why not. :P

Anyway, calling the old ioctl code if the new one fails, should be
compatible enough. (and the new structure contains the old one, so no
need of having 2 variables).

It would be even better if somebody finds out what the error for not
supported function is (I don't feel like checking 16000 error codes),
but it is not critical.