From: Ani Sinha <anisinha@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: bios-tables-test and iasl
Date: Wed, 17 May 2023 09:42:23 +0530 [thread overview]
Message-ID: <21AAB986-4A82-48DB-B0FF-7887C9F38EBC@redhat.com> (raw)
So I was working late scratching my head yesterday on why I was not getting my ASL diff on mismatched blobs! Turns out there were two things:
(a) iasl was not installed and I completely forgot about it because my old setup is gone and the new box is, well new and I did not get to mess around with tables up until now. This was easy to figure out.
(b) I recalled that previously all I had to do was install iasl and the binary would just produce the diff because it would discover iasl was in the PATH. Now it seemed no matter what I did I was not able to get the diff until I rebased and it triggered a clean build of qemu tree. Turns out, now we check iasl existence from meson and CONFIG_IASL is set from the build time (if not set, *iasl is NULL and no diff is generated).
So I wonder if we have made our lives any easier? Why should we need to rebuild the entire tree if all we wanted was to debug a test breakage? Sure we could always run iasl manually but isn’t it easier to simply run "V=1 make check-qtest” and let the test spit it out for us?
A
reply other threads:[~2023-05-17 4:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21AAB986-4A82-48DB-B0FF-7887C9F38EBC@redhat.com \
--to=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).