qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Ville Skyttä" <ville.skytta@iki.fi>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] docs: Grammar and spelling fixes
Date: Mon, 18 Jun 2018 16:46:02 -0500	[thread overview]
Message-ID: <21aaf5e7-a25c-0d07-1638-2537cb5360ce@redhat.com> (raw)
In-Reply-To: <CABr9L5B9Hspeq8tBe319Rct5XXFH3_NoxuxoVecSNg+-KXWP8g@mail.gmail.com>

On 06/14/2018 11:49 AM, Ville Skyttä wrote:
> On Tue, Jun 12, 2018 at 3:11 PM, Eric Blake <eblake@redhat.com> wrote:
>> On 06/12/2018 01:51 AM, Ville Skyttä wrote:
>>>
>>> Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
>>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>> ---
>>
>>
>> It's helpful to use 'git send-email -v3' (or 'git format-patch -v3',
>> depending on your workflow) so that the subject line tags this as a third
>> spin of the same patch previously posted, and to include, after the ---
>> separator, how it differs from v2 (in this case, incorporating my review
>> comment to reflow a long line).  Otherwise, automated tools might not pick
>> up on the fact that this email replaces your earlier submission as the one
>> to test.  Other submission tips can be found at:
>>
>> https://wiki.qemu.org/Contribute/SubmitAPatch
> 
> Ok, will keep that in mind for the future. In the meantime, am I still
> expected to do something to this latest patch, or just wait :)?

At this point, waiting is probably fine. If no one else responds after a 
week (such as a maintainer confirming they have queued it), then 
replying with a ping would be reasonable.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-06-18 21:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  6:51 [Qemu-devel] [PATCH] docs: Grammar and spelling fixes Ville Skyttä
2018-06-12 12:11 ` Eric Blake
2018-06-14 16:49   ` Ville Skyttä
2018-06-18 21:46     ` Eric Blake [this message]
2018-06-14 19:14 ` Markus Armbruster
2018-07-13 10:34 ` Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2018-06-11 20:25 Ville Skyttä
2018-06-11 22:00 ` Eric Blake
2018-06-12  6:51   ` Ville Skyttä
2018-06-11 14:25 Ville Skyttä
2018-06-11 15:23 ` Peter Maydell
2018-06-11 20:25   ` Ville Skyttä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21aaf5e7-a25c-0d07-1638-2537cb5360ce@redhat.com \
    --to=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ville.skytta@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).