From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flSxp-0000TB-DF for qemu-devel@nongnu.org; Fri, 03 Aug 2018 01:49:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flSxm-0007yO-C0 for qemu-devel@nongnu.org; Fri, 03 Aug 2018 01:49:25 -0400 References: <20180801035357.7804-1-david@gibson.dropbear.id.au> <20180802070824.GC11211@umbus.fritz.box> <20180802140744.GD11211@umbus.fritz.box> From: Thomas Huth Message-ID: <21de1d73-448a-36c2-0989-3de1f9d64a02@redhat.com> Date: Fri, 3 Aug 2018 07:49:12 +0200 MIME-Version: 1.0 In-Reply-To: <20180802140744.GD11211@umbus.fritz.box> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vhDYEKLfzPaHF9lVPEeKjzd2pTbaOhmt4" Subject: Re: [Qemu-devel] [Qemu-ppc] [PULL 0/2] ppc-for-3.0 queue 20180801 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , Peter Maydell Cc: Greg Kurz , qemu-ppc , QEMU Developers , BALATON Zoltan This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vhDYEKLfzPaHF9lVPEeKjzd2pTbaOhmt4 From: Thomas Huth To: David Gibson , Peter Maydell Cc: Greg Kurz , qemu-ppc , QEMU Developers , BALATON Zoltan Message-ID: <21de1d73-448a-36c2-0989-3de1f9d64a02@redhat.com> Subject: Re: [Qemu-ppc] [PULL 0/2] ppc-for-3.0 queue 20180801 References: <20180801035357.7804-1-david@gibson.dropbear.id.au> <20180802070824.GC11211@umbus.fritz.box> <20180802140744.GD11211@umbus.fritz.box> In-Reply-To: <20180802140744.GD11211@umbus.fritz.box> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 08/02/2018 04:07 PM, David Gibson wrote: > On Thu, Aug 02, 2018 at 10:16:32AM +0100, Peter Maydell wrote: >> On 2 August 2018 at 08:08, David Gibson = wrote: >>> The macio fix, however, *is* a regression from 2.12. Whether it's >>> severe enough to warrant another -rc, I'm not sure. It is a bad >>> pointer access which is, well, bad. It doesn't seem to bite >>> obviously, needing valgrind to pick it up, but possibly that's just >>> luck. >> >> I thought those introspection-bugs like the macio ones weren't >> regressions ? >=20 > Well, I ran Thomas's testcase on master and it generates several > valgrind warnings, which don't appear on either 2.12 or master+the > patch. Maybe the macio bug is something new, but we had plenty of these introspetion bugs in the other code (mainly the ARM code) which were clearly there since a looong time already and nobody ever complained. So it seems quite unusual that upper layer tools / the users are using the introspection feature of QEMU. Thus I'd say this bug is not important enough to block the release. We could fix it in the stable branch instead= =2E Thomas --vhDYEKLfzPaHF9lVPEeKjzd2pTbaOhmt4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJbY+zeAAoJEC7Z13T+cC21xjcP/imK+XUzEVMzhiAs44WRKrq+ lnBh7jNKsfs9HN4VM3YFNeWl63Gsr7hyTC4I1vGktTKcAFo2KkJEHdHxe/euXLTN PZyrCwxdHqQBZilBsZQ7WVGHy3FXPmRQcTqrovHiyw1hoqRwS0/L/G8rsa8tEd7M P50etPFk4LNHrwgUyyn4rsralnTp7g5GGIw59TWtzGj510YHjEeg4HP7vYqjDq4d Amu/S8gCXyRuNfBcOnJ2sqb2eWQhhK6/5JYV3b4l6HlmQ3sIQHNYj28JSHzEkYUd jo1PrDSnnFwgRHesxkBVyReryR9V++Nm7W+HnwjRyaWVSHBLovwM6uNM/HXg6G7d 0vhy2e+VpQ/aj2SVnxSutoR7fjuVD8AH0JeA2hv4BQaHAQEZFJskRmPajjEolkYf K9wHNxRyPWe8v3GEfme2iJw7hqk4Wbb5WIb1la9cY2ijDhG8f9rO0XhayKWz1VFH N0x+YZNg5AmZSQYh0IKF4l2z73at/7B+TrIHkjOiTku1qxwLo9P3gDut3puIfJQN DJqaDAyN9fmCDcWPVU9pX/B7wKrHk7MioD9enbe5Ve7M4A3L06yLrlkwR3XxEEp2 Clc7Z9rgP1k6Kb7qZOtQTa1sUh4FkiW396rmjg46o4Y1AWZvpYDjyFGUFWoXbTMy 2B1wbouWllMk38x4gwqj =eOGs -----END PGP SIGNATURE----- --vhDYEKLfzPaHF9lVPEeKjzd2pTbaOhmt4--