From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLBvb-0007Gq-Ra for qemu-devel@nongnu.org; Thu, 07 Jul 2016 12:13:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLBvW-0002Yk-Sm for qemu-devel@nongnu.org; Thu, 07 Jul 2016 12:13:27 -0400 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:38481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLBvW-0002YM-LN for qemu-devel@nongnu.org; Thu, 07 Jul 2016 12:13:22 -0400 Received: by mail-wm0-x234.google.com with SMTP id n127so22501035wme.1 for ; Thu, 07 Jul 2016 09:13:22 -0700 (PDT) Sender: Paolo Bonzini References: <1467735496-16256-1-git-send-email-alex.bennee@linaro.org> <20160707160439.GA28053@flamenco> From: Paolo Bonzini Message-ID: <21e93a61-c942-b503-c592-bc68b55454cd@redhat.com> Date: Thu, 7 Jul 2016 18:13:19 +0200 MIME-Version: 1.0 In-Reply-To: <20160707160439.GA28053@flamenco> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, jan.kiszka@siemens.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, serge.fdrv@gmail.com, bobby.prani@gmail.com, rth@twiddle.net, fred.konrad@greensocs.com On 07/07/2016 18:04, Emilio G. Cota wrote: >> > I think the first 3 patches are ready to take if the TCG maintainers >> > want to: >> > >> > tcg: Ensure safe tb_jmp_cache lookup out of 'tb_lock' >> > tcg: set up tb->page_addr before insertion >> > tcg: cpu-exec: remove tb_lock from the hot-path > I think it would be simpler to use tb_lock_recursive and > tb_lock_reset, as pointed out in v1 of this series. I agree, this series is doing a lot more restructuring than necessary. Paolo