From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] meson.build: Allow to disable OSS again
Date: Fri, 29 Oct 2021 11:32:29 +0200 [thread overview]
Message-ID: <21ebce18-cd60-3fa9-4b0a-97acc7fbc7c2@redhat.com> (raw)
In-Reply-To: <20211029071318.1780098-1-thuth@redhat.com>
On 10/29/21 09:13, Thomas Huth wrote:
> If sys/soundcard.h is available, it is currently not possible to
> disable OSS with the --disable-oss or --without-default-features
> configure switches. Improve the check in meson.build to fix this.
>
> Fixes: 87430d5b13 ("configure, meson: move audio driver detection to Meson")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> oss = not_found
> -if not get_option('oss').auto() or have_system
> +if get_option('oss').enabled() or (get_option('oss').auto() and have_system)
Shouldn't this be 'if have_system and (enabled or auto)' ?
> if not cc.has_header('sys/soundcard.h')
> # not found
> elif targetos == 'netbsd'
>
next prev parent reply other threads:[~2021-10-29 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 7:13 [PATCH] meson.build: Allow to disable OSS again Thomas Huth
2021-10-29 9:32 ` Philippe Mathieu-Daudé [this message]
2021-11-02 7:45 ` Thomas Huth
2021-11-02 8:01 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21ebce18-cd60-3fa9-4b0a-97acc7fbc7c2@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).