From: Richard Henderson <richard.henderson@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: philmd@linaro.org, ale@rev.ng, anjo@rev.ng, bcain@quicinc.com,
quic_mathbern@quicinc.com
Subject: Re: [PATCH v2 05/21] Hexagon (target/hexagon) Add overrides for clr[tf]new
Date: Fri, 28 Apr 2023 09:04:23 +0100 [thread overview]
Message-ID: <21f16356-56f5-1968-806e-744883b4e62e@linaro.org> (raw)
In-Reply-To: <20230427230012.3800327-6-tsimpson@quicinc.com>
On 4/27/23 23:59, Taylor Simpson wrote:
> These instructions have implicit reads from p0, so we don't want
> them in helpers when idef-parser is off.
>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> target/hexagon/gen_tcg.h | 16 ++++++++++++++++
> target/hexagon/macros.h | 4 ----
> 2 files changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h
> index 7c5cb93297..f3e9c280b0 100644
> --- a/target/hexagon/gen_tcg.h
> +++ b/target/hexagon/gen_tcg.h
> @@ -1097,6 +1097,22 @@
> gen_jump(ctx, riV); \
> } while (0)
>
> +/* if (p0.new) r0 = #0 */
> +#define fGEN_TCG_SA1_clrtnew(SHORTCODE) \
> + do { \
> + tcg_gen_movcond_tl(TCG_COND_EQ, RdV, \
> + hex_new_pred_value[0], tcg_constant_tl(0), \
> + RdV, tcg_constant_tl(0)); \
> + } while (0)
> +
> +/* if (!p0.new) r0 = #0 */
> +#define fGEN_TCG_SA1_clrfnew(SHORTCODE) \
> + do { \
> + tcg_gen_movcond_tl(TCG_COND_NE, RdV, \
> + hex_new_pred_value[0], tcg_constant_tl(0), \
> + RdV, tcg_constant_tl(0)); \
> + } while (0)
> +
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
> #define fGEN_TCG_J2_pause(SHORTCODE) \
> do { \
> uiV = uiV; \
> diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
> index 3e162de3a7..2cb0647ce2 100644
> --- a/target/hexagon/macros.h
> +++ b/target/hexagon/macros.h
> @@ -227,12 +227,8 @@ static inline void gen_cancel(uint32_t slot)
>
> #ifdef QEMU_GENERATE
> #define fLSBNEW(PVAL) tcg_gen_andi_tl(LSB, (PVAL), 1)
> -#define fLSBNEW0 tcg_gen_andi_tl(LSB, hex_new_pred_value[0], 1)
> -#define fLSBNEW1 tcg_gen_andi_tl(LSB, hex_new_pred_value[1], 1)
> #else
> #define fLSBNEW(PVAL) ((PVAL) & 1)
> -#define fLSBNEW0 (env->new_pred_value[0] & 1)
> -#define fLSBNEW1 (env->new_pred_value[1] & 1)
> #endif
>
> #ifdef QEMU_GENERATE
next prev parent reply other threads:[~2023-04-28 8:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 22:59 [PATCH v2 00/21] Hexagon (target/hexagon) short-circuit and move to DisasContext Taylor Simpson
2023-04-27 22:59 ` [PATCH v2 01/21] meson.build Add CONFIG_HEXAGON_IDEF_PARSER Taylor Simpson
2023-04-28 8:01 ` Richard Henderson
2023-04-27 22:59 ` [PATCH v2 02/21] Hexagon (target/hexagon) Add DisasContext arg to gen_log_reg_write Taylor Simpson
2023-04-27 22:59 ` [PATCH v2 03/21] Hexagon (target/hexagon) Add overrides for loop setup instructions Taylor Simpson
2023-04-27 22:59 ` [PATCH v2 04/21] Hexagon (target/hexagon) Add overrides for allocframe/deallocframe Taylor Simpson
2023-04-27 22:59 ` [PATCH v2 05/21] Hexagon (target/hexagon) Add overrides for clr[tf]new Taylor Simpson
2023-04-28 8:04 ` Richard Henderson [this message]
2023-04-27 22:59 ` [PATCH v2 06/21] Hexagon (target/hexagon) Remove log_reg_write from op_helper.[ch] Taylor Simpson
2023-04-27 22:59 ` [PATCH v2 07/21] Hexagon (target/hexagon) Eliminate uses of log_pred_write function Taylor Simpson
2023-04-27 22:59 ` [PATCH v2 08/21] Hexagon (target/hexagon) Clean up pred_written usage Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 09/21] Hexagon (target/hexagon) Don't overlap dest writes with source reads Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 10/21] Hexagon (target/hexagon) Mark registers as read during packet analysis Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 11/21] Hexagon (target/hexagon) Short-circuit packet register writes Taylor Simpson
2023-04-28 2:47 ` Brian Cain
2023-04-27 23:00 ` [PATCH v2 12/21] Hexagon (target/hexagon) Short-circuit packet predicate writes Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 13/21] Hexagon (target/hexagon) Short-circuit packet HVX writes Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 14/21] Hexagon (target/hexagon) Short-circuit more HVX single instruction packets Taylor Simpson
2023-04-28 8:09 ` Richard Henderson
2023-04-27 23:00 ` [PATCH v2 15/21] Hexagon (target/hexagon) Add overrides for disabled idef-parser insns Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 16/21] Hexagon (target/hexagon) Make special new_value for USR Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 17/21] Hexagon (target/hexagon) Move new_value to DisasContext Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 18/21] Hexagon (target/hexagon) Move new_pred_value " Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 19/21] Hexagon (target/hexagon) Move pred_written " Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 20/21] Hexagon (target/hexagon) Move pkt_has_store_s1 " Taylor Simpson
2023-04-27 23:00 ` [PATCH v2 21/21] Hexagon (target/hexagon) Move items " Taylor Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21f16356-56f5-1968-806e-744883b4e62e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).