From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Aurelien Jarno <aurelien@aurel32.net>,
cohuck@redhat.com, borntraeger@de.ibm.com,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to s390-virtio-hcall.h
Date: Thu, 31 Aug 2017 15:18:08 +0200 [thread overview]
Message-ID: <21f4d734-8d7c-5ee9-33e2-0cc829d7d8ca@redhat.com> (raw)
In-Reply-To: <98048e5d-fa10-76a3-ce11-36a78212c259@redhat.com>
On 31.08.2017 11:29, Thomas Huth wrote:
> On 30.08.2017 19:05, David Hildenbrand wrote:
>> The only interface left, so let's properly rename it.
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>> hw/s390x/s390-virtio-ccw.c | 2 +-
>> hw/s390x/s390-virtio-hcall.c | 2 +-
>> hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>> rename hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} (92%)
> [...]
>> diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio-hcall.h
>> similarity index 92%
>> rename from hw/s390x/s390-virtio.h
>> rename to hw/s390x/s390-virtio-hcall.h
>> index d984cd4115..64c5bbd827 100644
>> --- a/hw/s390x/s390-virtio.h
>> +++ b/hw/s390x/s390-virtio-hcall.h
>> @@ -1,5 +1,5 @@
>> /*
>> - * Virtio interfaces for s390
>> + * Support for virtio hypercalls on s390x
>> *
>> * Copyright 2012 IBM Corp.
>> * Author(s): Cornelia Huck <cornelia.huck@de.ibm.com>
>>
>
> Maybe also rename the HW_S390_VIRTIO_H header guard? Anyway:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
Sure, will do. Is HW_S390_VIRTIO_HCALL_H okay?
(HW_S390X_S390_VIRTIO_HCALL_H doesn't sound necessary)
--
Thanks,
David
next prev parent reply other threads:[~2017-08-31 13:18 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 17:05 [Qemu-devel] [PATCH v1 00/11] next round of s390x cleanups David Hildenbrand
2017-08-30 17:05 ` [Qemu-devel] [PATCH v1 01/11] exec, dump: don't include exec/exec-all.h explicitly David Hildenbrand
2017-08-30 18:55 ` Thomas Huth
2017-08-31 13:06 ` David Hildenbrand
2017-08-31 14:21 ` Cornelia Huck
2017-09-01 15:18 ` David Hildenbrand
2017-08-30 17:05 ` [Qemu-devel] [PATCH v1 02/11] cpu: drop old comments describing members David Hildenbrand
2017-08-31 14:23 ` Cornelia Huck
2017-08-30 17:05 ` [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state David Hildenbrand
2017-08-30 20:58 ` Thomas Huth
2017-08-31 13:11 ` David Hildenbrand
2017-08-31 14:29 ` Cornelia Huck
2017-08-31 14:30 ` David Hildenbrand
2017-08-31 14:38 ` Cornelia Huck
2017-08-31 14:39 ` David Hildenbrand
2017-08-31 14:23 ` David Hildenbrand
2017-08-31 14:31 ` Thomas Huth
2017-08-31 14:36 ` David Hildenbrand
2017-08-31 14:45 ` Thomas Huth
2017-08-30 17:05 ` [Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c David Hildenbrand
2017-08-31 9:13 ` Thomas Huth
2017-08-31 13:14 ` David Hildenbrand
2017-08-31 11:47 ` Christian Borntraeger
2017-08-31 13:13 ` David Hildenbrand
2017-08-30 17:05 ` [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to s390-virtio-hcall.h David Hildenbrand
2017-08-31 9:29 ` Thomas Huth
2017-08-31 13:18 ` David Hildenbrand [this message]
2017-08-31 13:20 ` Thomas Huth
2017-08-30 17:05 ` [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu number/address handling David Hildenbrand
2017-08-31 14:35 ` Cornelia Huck
2017-08-31 14:41 ` David Hildenbrand
2017-08-31 14:49 ` Cornelia Huck
2017-08-31 16:03 ` Igor Mammedov
2017-08-31 16:08 ` Cornelia Huck
2017-08-30 17:05 ` [Qemu-devel] [PATCH v1 07/11] target/s390x: rename next_cpu_id to next_cpu_addr David Hildenbrand
2017-08-30 17:05 ` [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG David Hildenbrand
2017-08-30 19:06 ` Thomas Huth
2017-08-31 6:42 ` Cornelia Huck
2017-08-31 13:24 ` David Hildenbrand
2017-08-31 14:41 ` Cornelia Huck
2017-08-31 15:03 ` David Hildenbrand
2017-08-31 15:07 ` Cornelia Huck
2017-08-31 15:33 ` David Hildenbrand
2017-08-31 16:06 ` Cornelia Huck
2017-08-30 17:05 ` [Qemu-devel] [PATCH v1 09/11] target/s390x: tcg_s390_program_interrupt() will never return David Hildenbrand
2017-08-30 20:45 ` Thomas Huth
2017-08-31 12:14 ` David Hildenbrand
2017-08-30 17:06 ` [Qemu-devel] [PATCH v1 10/11] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault() David Hildenbrand
2017-08-30 19:11 ` Thomas Huth
2017-08-31 13:34 ` David Hildenbrand
2017-08-30 17:06 ` [Qemu-devel] [PATCH v1 11/11] target/s390x: use program_interrupt() in per_check_exception() David Hildenbrand
2017-08-31 9:37 ` Thomas Huth
2017-08-31 14:45 ` [Qemu-devel] [PATCH v1 00/11] next round of s390x cleanups Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21f4d734-8d7c-5ee9-33e2-0cc829d7d8ca@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).