qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH v3 3/3] hw/ipack: Remove legacy qemu_allocate_irqs() use
Date: Tue, 21 Jan 2025 15:03:12 -0800	[thread overview]
Message-ID: <21f53d1e-3760-4ca3-a662-e3f48b7b49ba@linaro.org> (raw)
In-Reply-To: <20250121155526.29982-4-philmd@linaro.org>

On 1/21/25 07:55, Philippe Mathieu-Daudé wrote:
> No need to dynamically allocate IRQ when we know before hands
> how many we'll use. Declare the 2 of them in IPackDevice state
> and initialize them in the DeviceRealize handler.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   include/hw/ipack/ipack.h | 7 ++-----
>   hw/char/ipoctal232.c     | 4 ++--
>   hw/ipack/ipack.c         | 5 +----
>   hw/ipack/tpci200.c       | 6 +++---
>   4 files changed, 8 insertions(+), 14 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2025-01-21 23:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 15:55 [PATCH v3 0/3] hw/ipack: Minor dust removal Philippe Mathieu-Daudé
2025-01-21 15:55 ` [PATCH v3 1/3] hw/irq: Introduce qemu_init_irqs() helper Philippe Mathieu-Daudé
2025-01-21 23:02   ` Richard Henderson
2025-01-21 15:55 ` [PATCH v3 2/3] hw/ipack: Clarify KConfig symbols Philippe Mathieu-Daudé
2025-01-22  7:02   ` Philippe Mathieu-Daudé
2025-01-21 15:55 ` [PATCH v3 3/3] hw/ipack: Remove legacy qemu_allocate_irqs() use Philippe Mathieu-Daudé
2025-01-21 23:03   ` Richard Henderson [this message]
2025-01-30 21:47 ` [PATCH v3 0/3] hw/ipack: Minor dust removal Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21f53d1e-3760-4ca3-a662-e3f48b7b49ba@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).