From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Stefan Liebler <stli@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Andreas Krebbel <Andreas.Krebbel@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 2/2] s390x/tcg: Store only the necessary amount of doublewords for STFLE
Date: Fri, 31 May 2019 17:08:17 +0200 [thread overview]
Message-ID: <21f88571-de38-5ea4-3904-192c3e96738e@redhat.com> (raw)
In-Reply-To: <399b78dc-8a1f-65a2-2e00-15460dbbe4bb@linaro.org>
On 31.05.19 17:05, Richard Henderson wrote:
> On 5/31/19 9:56 AM, David Hildenbrand wrote:
>> @@ -678,7 +678,7 @@ uint32_t HELPER(stfle)(CPUS390XState *env, uint64_t addr)
>>
>> prepare_stfl();
>> max_bytes = ROUND_UP(used_stfl_bytes, 8);
>> - for (i = 0; i < count_bytes; ++i) {
>> + for (i = 0; i < MIN(count_bytes, max_bytes); ++i) {
>
> Before the loop, please put something like
>
> /*
> * The PoP says that doublewords beyond the highest-numbered
> * facility bit may or may not be stored. However, existing
> * hardware appears to not store the words, and existing
> * software appears to depend on that.
> */
>
> with that,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
Makes sense, thanks for the ultra-fast review!
(have a great weekend!)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-05-31 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 14:56 [Qemu-devel] [PATCH v1 0/2] s390x/tcg: STFLE fixes David Hildenbrand
2019-05-31 14:56 ` [Qemu-devel] [PATCH v1 1/2] s390x/tcg: Fix max_byte detection for stfle David Hildenbrand
2019-05-31 15:02 ` Richard Henderson
2019-05-31 14:56 ` [Qemu-devel] [PATCH v1 2/2] s390x/tcg: Store only the necessary amount of doublewords for STFLE David Hildenbrand
2019-05-31 15:05 ` Richard Henderson
2019-05-31 15:08 ` David Hildenbrand [this message]
2019-06-03 10:38 ` Stefan Liebler
2019-06-03 10:45 ` David Hildenbrand
2019-06-03 14:39 ` Stefan Liebler
2019-06-04 8:11 ` David Hildenbrand
2019-06-03 7:02 ` [Qemu-devel] [PATCH v1 0/2] s390x/tcg: STFLE fixes Cornelia Huck
2019-06-03 7:16 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21f88571-de38-5ea4-3904-192c3e96738e@redhat.com \
--to=david@redhat.com \
--cc=Andreas.Krebbel@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=stli@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).