From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF6BC433E0 for ; Mon, 25 Jan 2021 14:08:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC95B2229C for ; Mon, 25 Jan 2021 14:08:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC95B2229C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l42Xg-0007Dq-Uz for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 09:08:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l42Vq-0005vy-9w for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:06:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l42Vo-0000fe-Rm for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:06:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611583595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BbqtbeXI3GlAIHlu5yobqjxEb59D/eFycCVsATaQOKw=; b=WlOxHXGKXa2sv6HIm/MejX0iYZ+NVQXNCKVeytZJUzDiOH950Im8ENX6CD03XVtwrVVr5i gQH/Q3/Z8pvQSXx8JSpGkgKrb26KUCrICA6gTt9Efo1VhtLfxkTSBcw6vT1btUX8yVSnRA pdWnbeQQ/NUGCZUHUDsPMAHdWfO49l4= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-33-q2VMru5xOW6kos0sff8UGg-1; Mon, 25 Jan 2021 09:06:34 -0500 X-MC-Unique: q2VMru5xOW6kos0sff8UGg-1 Received: by mail-ed1-f70.google.com with SMTP id y6so7464533edc.17 for ; Mon, 25 Jan 2021 06:06:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BbqtbeXI3GlAIHlu5yobqjxEb59D/eFycCVsATaQOKw=; b=JZ6F3BzlkTJJBjXD75betFL5KNltILD13YawTNnmtXkxa86bvc8KtTuF+oWGFUmD36 Li80BZIq2H5vSjNr4FfPGyr99QaJPcPrQifKN0OQnkROaOHEVL9gtvC8/3Y7Q3XFg8gP VgRa2aGaveDf92g3i5Y5rA5HYGWQEpsdOHYit1VpQAb/HodXiJdBLdBgYAsR8awEDo0N U8LMDroD6Wtj+uVrtQ5nXG66eCPgKUISTIYdYDyAIoKw8zSt05QMTBiSoln2NAjEzCSq /kvnVtx2/NaLvZJ/yo4cvdReci8GW7mLDOouq9MqtD2yyPdYdnd1aT2SkgCte+hoWtY/ hB+Q== X-Gm-Message-State: AOAM531Qt1YJBGDh8LfRRzwC1X7qWp46yefvMx7dII4cqRlBAvfvTXr4 P/uQofqCeLL4xtEuews4W0zJREKPsP3RtjPbnEUGfG5HIQe/I+029pz8I6uDKtHTWD+f1Ldwelw Dn5EZXt951uli7hM= X-Received: by 2002:aa7:ca13:: with SMTP id y19mr582711eds.59.1611583592883; Mon, 25 Jan 2021 06:06:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJyHF9+CIwp/coybHxcCe8enNF5XeXYHpf15sCln35IY/iKaT52uKE8ZYbR0vmO6BAVQP8RUQQ== X-Received: by 2002:aa7:ca13:: with SMTP id y19mr582696eds.59.1611583592671; Mon, 25 Jan 2021 06:06:32 -0800 (PST) Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id n2sm856970ejl.1.2021.01.25.06.06.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 06:06:31 -0800 (PST) Subject: Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable To: Stefan Hajnoczi , qemu-devel@nongnu.org, Paolo Bonzini References: <20210125113507.224287-1-stefanha@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <220bc0d1-4d1d-eeaf-6e2e-66fa33de8f98@redhat.com> Date: Mon, 25 Jan 2021 15:06:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210125113507.224287-1-stefanha@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Berrange , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Stefan, On 1/25/21 12:35 PM, Stefan Hajnoczi wrote: > Zoltan reminded me that the 'log' backend prints tids/timestamps and this can > be unwanted in some cases. It's easier to look at trace output without them and > in some cases parsing is also more convenient with them. > > Extend -msg timestamp=on|off to control the 'log' backend's tid/timestamp output. > > Stefan Hajnoczi (2): > error: rename error_with_timestamp to message_with_timestamp > trace: make the 'log' backend timestamp configurable > > docs/devel/tracing.txt | 3 +++ > include/qemu/error-report.h | 2 +- > softmmu/vl.c | 2 +- > util/qemu-error.c | 4 ++-- > scripts/tracetool/backend/log.py | 19 +++++++++++++------ > 5 files changed, 20 insertions(+), 10 deletions(-) I applied your series, rebuilt, but nothing changed. Apparently there is some buildsys rule missing, the trace files weren't regenerated. After full tree 'make clean' I could successfully test: Tested-by: Philippe Mathieu-Daudé Ignoring the buildsys issue: Reviewed-by: Philippe Mathieu-Daudé Regards, Phil.