From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9709CD0BB61 for ; Thu, 24 Oct 2024 06:13:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3r62-0005B3-Vr; Thu, 24 Oct 2024 02:13:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3r5y-00058r-B3; Thu, 24 Oct 2024 02:13:18 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76] helo=mail.ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3r5t-0000TG-Tl; Thu, 24 Oct 2024 02:13:15 -0400 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4XYwZX2vmtz4wb1; Thu, 24 Oct 2024 17:13:08 +1100 (AEDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4XYwZQ6d9Mz4w2F; Thu, 24 Oct 2024 17:13:02 +1100 (AEDT) Message-ID: <2213d24e-b77c-43ed-87be-a00c70f001e0@kaod.org> Date: Thu, 24 Oct 2024 08:13:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/18] aspeed/smc: Fix write incorrect data into flash in user mode To: Jamin Lin , Kevin Wolf Cc: Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , Alistair Francis , Hanna Reitz , Thomas Huth , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" , "open list:Block layer core" , Troy Lee , Yunlin Tang References: <20241022094110.1574011-1-jamin_lin@aspeedtech.com> <20241022094110.1574011-2-jamin_lin@aspeedtech.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=9NnO=RU=kaod.org=clg@ozlabs.org; helo=mail.ozlabs.org X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.17, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/23/24 03:41, Jamin Lin wrote: > Hi Cedric, > >> Subject: Re: [PATCH v2 01/18] aspeed/smc: Fix write incorrect data into flash in >> user mode >> >>>> >>>> static const VMStateDescription vmstate_aspeed_smc = { >>>> .name = "aspeed.smc", >>>> - .version_id = 2, >>>> + .version_id = 3, >>>> .minimum_version_id = 2, >>>> .fields = (const VMStateField[]) { >>>> VMSTATE_UINT32_ARRAY(regs, AspeedSMCState, >> ASPEED_SMC_R_MAX), >>>> VMSTATE_UINT8(snoop_index, AspeedSMCState), >>>> VMSTATE_UINT8(snoop_dummies, AspeedSMCState), >>>> + VMSTATE_BOOL(unselect, AspeedSMCState), >>>> VMSTATE_END_OF_LIST() >>>> } >>>> }; >>> >>> I think this will break migration compatibility. In order to enable at >>> least forward migration, it should be: >>> >>> VMSTATE_BOOL_V(unselect, AspeedSMCState, 3), >> >> This is correct. I will fix the patch. >> > If I need to re-send v3 patch, I will fix it. I took care of it. No need to resend. Thanks C.