qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: 오유연 <yuyeon.oh@samsung.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel]  [PATCH] target-arm: fix LDMIA bug on page boundary
Date: Sun, 24 Apr 2011 14:47:57 +0000 (GMT)	[thread overview]
Message-ID: <22217409.4971303656477646.JavaMail.weblogic@epml25> (raw)

When consecutive memory locations are on page boundary, a base register may be
loaded before page fault occurs. After page fault handling, it losts the memory
location information. To solve this problem, loading a base register has to put back.

Signed-off-by: Yuyeon Oh <yuyeon.oh@samsung.com>
---
 target-arm/translate.c |   18 +++++++++++++-----
 1 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/target-arm/translate.c b/target-arm/translate.c
index e1bda57..61eb4d5 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -7984,11 +7984,16 @@ static int disas_thumb2_insn(CPUState *env, DisasContext *s, uint16_t insn_hw1)
                         continue;
                     if (insn & (1 << 20)) {
                         /* Load.  */
-                        tmp = gen_ld32(addr, IS_USER(s));
-                        if (i == 15) {
-                            gen_bx(s, tmp);
-                        } else {
-                            store_reg(s, i, tmp);
+                        if (i == rn) {
+                            tmp2 = gen_ld32(addr, IS_USER(s));
+                        }
+                        else {
+                            tmp = gen_ld32(addr, IS_USER(s));
+                            if (i == 15) {
+                                gen_bx(s, tmp);
+                            } else {
+                                store_reg(s, i, tmp);
+                            }
                         }
                     } else {
                         /* Store.  */
@@ -7997,6 +8002,9 @@ static int disas_thumb2_insn(CPUState *env, DisasContext *s, uint16_t insn_hw1)
                     }
                     tcg_gen_addi_i32(addr, addr, 4);
                 }
+                if ((insn & (1 << 20)) && (insn & (1 << rn))) {
+                    store_reg(s, rn, tmp2);
+                }
                 if (insn & (1 << 21)) {
                     /* Base register writeback.  */
                     if (insn & (1 << 24)) {
-- 
1.7.4.msysgit.0


             reply	other threads:[~2011-04-24 14:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-24 14:47 오유연 [this message]
2011-04-24 15:25 ` [Qemu-devel] [PATCH] target-arm: fix LDMIA bug on page boundary Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2011-04-25  1:19 YuYeon Oh
2011-04-25  1:23 YuYeon Oh
2011-04-26 17:17 ` Peter Maydell
2011-04-27 18:18 ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22217409.4971303656477646.JavaMail.weblogic@epml25 \
    --to=yuyeon.oh@samsung.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).