From: David Hildenbrand <david@redhat.com>
To: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, borntraeger@de.ibm.com
Cc: Thomas Huth <thuth@redhat.com>,
cohuck@redhat.com, Alexander Graf <agraf@suse.de>,
qemu-s390x@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v1] target/s390x: change CPU type name to "s390x-cpu"
Date: Wed, 25 Oct 2017 11:39:39 +0200 [thread overview]
Message-ID: <2228fd2c-eda0-ab81-50e6-cb3570d1fc30@redhat.com> (raw)
In-Reply-To: <a889832b-ade3-f924-e49d-386052ae6ff0@redhat.com>
On 20.10.2017 17:26, Eric Blake wrote:
> On 10/20/2017 06:58 AM, David Hildenbrand wrote:
>> For now, e.g. host-s390-cpu wasn't exposed to the user. cpu-add, -cpu
>> and the CPU model qmp interfaces didn't care about the actual type,
>> as that information was hidden.
>>
>> This changed with CPU hotplug via device_add. Now the type is visible to
>> the user. Before we get that supported in a stable version, this is our
>> last chance to change it.
>>
>> So change it form "s390-cpu" to "s390x-cpu", to match the architecture
>
> s/form/from/
>
>> name. Example names are then e.g. z14-s390x-cpu or qemu-s390x-cpu.
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>
>
If there are no objections, Christian can you pick this up (fixing the
typo) so we get this into 2.11?
--
Thanks,
David
next prev parent reply other threads:[~2017-10-25 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 11:58 [Qemu-devel] [PATCH v1] target/s390x: change CPU type name to "s390x-cpu" David Hildenbrand
2017-10-20 12:44 ` Thomas Huth
2017-10-20 15:23 ` David Hildenbrand
2017-10-20 15:26 ` Eric Blake
2017-10-25 9:39 ` David Hildenbrand [this message]
2017-10-25 9:52 ` Cornelia Huck
2017-10-25 10:12 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2228fd2c-eda0-ab81-50e6-cb3570d1fc30@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).