From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VntfN-0008Cw-TI for qemu-devel@nongnu.org; Tue, 03 Dec 2013 12:21:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VntfJ-0001Xs-4f for qemu-devel@nongnu.org; Tue, 03 Dec 2013 12:21:45 -0500 Date: Tue, 3 Dec 2013 12:21:29 -0500 (EST) From: Paolo Bonzini Message-ID: <223842567.34743368.1386091289854.JavaMail.root@redhat.com> In-Reply-To: <20131203171822.GA15093@srcf.ucam.org> References: <1385408563-14331-1-git-send-email-matthew.garrett@nebula.com> <20131203171822.GA15093@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: Fix rate limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Garrett Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, quintela@redhat.com > On Mon, Nov 25, 2013 at 02:42:43PM -0500, Matthew Garrett wrote: > > The migration thread appears to want to allow writeout to occur at full > > speed rather than being rate limited during completion of state saving, > > but sets the limit to INT_MAX when xfer_limit is INT64_MAX. This causes > > problems if there's more than 2GB of state left to save at this point. It > > probably ought to just be INT64_MAX instead. > > > > Signed-off-by: Matthew Garrett > > --- > > migration.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/migration.c b/migration.c > > index 2b1ab20..ff00bfb 100644 > > --- a/migration.c > > +++ b/migration.c > > @@ -583,7 +583,7 @@ static void *migration_thread(void *opaque) > > > > ret = vm_stop_force_state(RUN_STATE_FINISH_MIGRATE); > > if (ret >= 0) { > > - qemu_file_set_rate_limit(s->file, INT_MAX); > > + qemu_file_set_rate_limit(s->file, INT64_MAX); > > qemu_savevm_state_complete(s->file); > > } > > qemu_mutex_unlock_iothread(); > > -- > > 1.8.4.2 I didn't see this, Cc: qemu-stable@nongnu.org Reviewed-by: Paolo Bonzini