From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
QEMU Developers <qemu-devel@nongnu.org>,
Greg Kurz <groug@kaod.org>,
"open list:sPAPR" <qemu-ppc@nongnu.org>,
Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PULL 10/10] ppc/pnv: Create BMC devices only when defaults are enabled
Date: Mon, 22 Jun 2020 10:27:25 +0200 [thread overview]
Message-ID: <22a6705d-3206-3133-eebb-35e8735a48d5@redhat.com> (raw)
In-Reply-To: <919a0804-3ea0-dc05-c789-224919be66c8@kaod.org>
On 6/22/20 9:09 AM, Cédric Le Goater wrote:
> On 6/19/20 8:02 PM, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> On Tue, Apr 7, 2020 at 6:42 AM David Gibson <david@gibson.dropbear.id.au> wrote:
>>>
>>> From: Cédric Le Goater <clg@kaod.org>
>>>
>>> Commit e2392d4395dd ("ppc/pnv: Create BMC devices at machine init")
>>> introduced default BMC devices which can be a problem when the same
>>> devices are defined on the command line with :
>>>
>>> -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10
>>>
>>> QEMU fails with :
>>>
>>> qemu-system-ppc64: error creating device tree: node: FDT_ERR_EXISTS
>>>
>>> Use defaults_enabled() when creating the default BMC devices to let
>>> the user provide its own BMC devices using '-nodefaults'. If no BMC
>>> device are provided, output a warning but let QEMU run as this is a
>>> supported configuration. However, when multiple BMC devices are
>>> defined, stop QEMU with a clear error as the results are unexpected.
>>>
>>> Fixes: e2392d4395dd ("ppc/pnv: Create BMC devices at machine init")
>>> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>> Message-Id: <20200404153655.166834-1-clg@kaod.org>
>>> Tested-by: Nathan Chancellor <natechancellor@gmail.com>
>>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>>> ---
>>
>> Not sure if directly related to this patch, but on gitlab-ci we get:
>>
>> TEST check-qtest-ppc64: tests/qtest/m48t59-test
>> TEST check-qtest-ppc64: tests/qtest/device-plug-test
>> TEST check-qtest-ppc64: tests/qtest/pnv-xscom-test
>> TEST check-qtest-ppc64: tests/qtest/migration-test
>> TEST check-qtest-ppc64: tests/qtest/rtas-test
>> TEST check-qtest-ppc64: tests/qtest/usb-hcd-uhci-test
>> TEST check-qtest-ppc64: tests/qtest/usb-hcd-xhci-test
>> TEST check-qtest-ppc64: tests/qtest/test-filter-mirror
>> TEST check-qtest-ppc64: tests/qtest/test-filter-redirector
>> TEST check-qtest-ppc64: tests/qtest/display-vga-test
>> TEST check-qtest-ppc64: tests/qtest/numa-test
>> TEST check-qtest-ppc64: tests/qtest/ivshmem-test
>> TEST check-qtest-ppc64: tests/qtest/cpu-plug-test
>> TEST check-qtest-ppc64: tests/qtest/cdrom-test
>> TEST check-qtest-ppc64: tests/qtest/device-introspect-test
>> qemu-system-ppc64: warning: machine has no BMC device. Use '-device
>> ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10' to define
>> one
>> qemu-system-ppc64: warning: machine has no BMC device. Use '-device
>> ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10' to define
>> one
>> qemu-system-ppc64: warning: machine has no BMC device. Use '-device
>> ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10' to define
>> one
>
> I can not reproduce. Is gitlab-ci doing something special ?
(Greg already answered elsewhere, for for other readers):
The test is ran when using:
$ make check-qtest SPEED=slow
next prev parent reply other threads:[~2020-06-22 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 4:35 [PULL 00/10] ppc-for-5.0 queue 20200407 David Gibson
2020-04-07 4:35 ` [PULL 01/10] hw/ppc/e500.c: Handle qemu_find_file() failure David Gibson
2020-04-07 4:35 ` [PULL 02/10] vfio/spapr: Fix page size calculation David Gibson
2020-04-07 4:35 ` [PULL 03/10] ppc/spapr: KVM FWNMI should not be enabled until guest requests it David Gibson
2020-04-07 4:36 ` [PULL 04/10] ppc/spapr: Improve FWNMI machine check delivery corner case comments David Gibson
2020-04-07 4:36 ` [PULL 05/10] ppc/spapr: Add FWNMI machine check delivery warnings David Gibson
2020-04-07 4:36 ` [PULL 06/10] ppc/spapr: Don't kill the guest if a recovered FWNMI machine check delivery fails David Gibson
2020-04-07 4:36 ` [PULL 07/10] spapr: Fix failure path for attempting to hot unplug PCI bridges David Gibson
2020-04-07 4:36 ` [PULL 08/10] hw/ppc/ppc440_uc.c: Remove incorrect iothread locking from dcr_write_pcie() David Gibson
2020-04-07 4:36 ` [PULL 09/10] pseries: Update SLOF firmware image David Gibson
2020-04-07 4:36 ` [PULL 10/10] ppc/pnv: Create BMC devices only when defaults are enabled David Gibson
2020-06-19 18:02 ` Philippe Mathieu-Daudé
2020-06-22 7:09 ` Cédric Le Goater
2020-06-22 8:27 ` Philippe Mathieu-Daudé [this message]
2020-04-07 13:01 ` [PULL 00/10] ppc-for-5.0 queue 20200407 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22a6705d-3206-3133-eebb-35e8735a48d5@redhat.com \
--to=philmd@redhat.com \
--cc=aik@ozlabs.ru \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=natechancellor@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).