From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLakZ-00023W-L2 for qemu-devel@nongnu.org; Wed, 23 May 2018 16:52:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLakY-00076p-RM for qemu-devel@nongnu.org; Wed, 23 May 2018 16:52:47 -0400 References: <1527091418-11874-1-git-send-email-eric.auger@redhat.com> From: Laszlo Ersek Message-ID: <22c4e504-a7b4-e6dd-b2cc-618d306b6f0c@redhat.com> Date: Wed, 23 May 2018 22:52:34 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/2] ARM virt: Support up to 256 PCIe buses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Auger Eric , eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org Cc: wei@redhat.com, drjones@redhat.com, ard.biesheuvel@linaro.org, zhaoshenglong@huawei.com On 05/23/18 22:40, Auger Eric wrote: > On 05/23/2018 07:45 PM, Laszlo Ersek wrote: >> Regarding the second patch, I do believe we need "more sophistication" >> there. For example, I guess it could be possible to distinguish "-cpu >> cortex-a15" from "-cpu cortex-a57" somehow, and stick with the low/small >> ECAM in the former case. (The 32-bit firmware already runs on cortex-a15 >> only, and not on cortex-a57, according to my testing.) > > So we should detect we are in ACPI boot + aarch32 mode to force legacy > ECAM region, right? Agree about the aarch32 subcondition. However, "ACPI vs. DT" is not the right "other" subcondition here; instead we should (minimally) check "firmware vs. no firmware". See the "firmware_loaded" boolean field. I also suggest waiting for feedback from others! :) Thanks, Laszlo