From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 01/17] block: access copy_on_read with atomic ops
Date: Thu, 4 May 2017 13:51:20 +0200 [thread overview]
Message-ID: <22c7d16c-116a-3d28-8cc8-88f737ee7cc8@redhat.com> (raw)
In-Reply-To: <20170504111536.GG32376@stefanha-x1.localdomain>
On 04/05/2017 13:15, Stefan Hajnoczi wrote:
> On Thu, Apr 20, 2017 at 02:00:42PM +0200, Paolo Bonzini wrote:
>> void bdrv_disable_copy_on_read(BlockDriverState *bs)
>> {
>> - assert(bs->copy_on_read > 0);
>> - bs->copy_on_read--;
>> + assert(atomic_read(&bs->copy_on_read) > 0);
>> + atomic_dec(&bs->copy_on_read);
>> }
>
> To make this truly thread-safe:
>
> old = atomic_dec_fetch(&bs->copy_on_read);
> assert(old > 0);
Good point. It feels wrong to assert after the fact, but then so does
making the assertion not quite thread safe.
Paolo
next prev parent reply other threads:[~2017-05-04 11:51 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 12:00 [Qemu-devel] [PATCH for 2.10 00/17] Block layer thread safety, part 1 Paolo Bonzini
2017-04-20 12:00 ` [Qemu-devel] [PATCH 01/17] block: access copy_on_read with atomic ops Paolo Bonzini
2017-05-04 11:15 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-05-04 11:51 ` Paolo Bonzini [this message]
2017-04-20 12:00 ` [Qemu-devel] [PATCH 02/17] block: access quiesce_counter " Paolo Bonzini
2017-05-04 12:33 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 03/17] block: access io_limits_disabled " Paolo Bonzini
2017-05-04 12:38 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 04/17] block: access serialising_in_flight " Paolo Bonzini
2017-05-04 12:39 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 05/17] block: access wakeup " Paolo Bonzini
2017-05-04 6:39 ` Fam Zheng
2017-05-04 7:12 ` Paolo Bonzini
2017-05-04 12:47 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 06/17] block: access io_plugged " Paolo Bonzini
2017-05-04 12:48 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 07/17] throttle-groups: do not use qemu_co_enter_next Paolo Bonzini
2017-05-04 13:27 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 08/17] throttle-groups: protect throttled requests with a CoMutex Paolo Bonzini
2017-05-04 6:57 ` Fam Zheng
2017-05-04 13:56 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 09/17] util: add stats64 module Paolo Bonzini
2017-05-04 7:19 ` Fam Zheng
2017-05-04 7:24 ` Paolo Bonzini
2017-05-04 7:36 ` Fam Zheng
2017-05-04 7:38 ` Paolo Bonzini
2017-05-04 8:55 ` [Qemu-devel] [Qemu-block] " Roman Kagan
2017-05-04 9:46 ` Paolo Bonzini
2017-04-20 12:00 ` [Qemu-devel] [PATCH 10/17] block: use Stat64 for wr_highest_offset Paolo Bonzini
2017-05-04 14:02 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 11/17] block: access write_gen with atomics Paolo Bonzini
2017-05-04 14:04 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 12/17] block: protect tracked_requests and flush_queue with reqs_lock Paolo Bonzini
2017-05-04 7:30 ` Fam Zheng
2017-05-04 8:35 ` Paolo Bonzini
2017-04-20 12:00 ` [Qemu-devel] [PATCH 13/17] coroutine-lock: introduce qemu_co_mutex_lock_unlock Paolo Bonzini
2017-05-04 7:39 ` Fam Zheng
2017-05-04 9:47 ` Paolo Bonzini
2017-05-04 9:52 ` Paolo Bonzini
2017-05-04 14:12 ` Stefan Hajnoczi
2017-05-04 16:17 ` Paolo Bonzini
2017-04-20 12:00 ` [Qemu-devel] [PATCH 14/17] block: optimize access to reqs_lock Paolo Bonzini
2017-05-04 14:59 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-05-04 16:06 ` Paolo Bonzini
2017-05-05 10:25 ` Stefan Hajnoczi
2017-05-05 10:45 ` Paolo Bonzini
2017-05-08 16:21 ` Stefan Hajnoczi
2017-05-08 16:30 ` Paolo Bonzini
2017-04-20 12:00 ` [Qemu-devel] [PATCH 15/17] block: introduce dirty_bitmap_mutex Paolo Bonzini
2017-05-04 7:55 ` Fam Zheng
2017-05-04 9:57 ` Paolo Bonzini
2017-04-20 12:00 ` [Qemu-devel] [PATCH 16/17] block: protect modification of dirty bitmaps with a mutex Paolo Bonzini
2017-04-20 14:42 ` Eric Blake
2017-05-04 8:05 ` Fam Zheng
2017-05-04 10:05 ` Paolo Bonzini
2017-05-05 10:36 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-05-05 10:47 ` Paolo Bonzini
2017-05-08 16:17 ` Stefan Hajnoczi
2017-04-20 12:00 ` [Qemu-devel] [PATCH 17/17] block: make accounting thread-safe Paolo Bonzini
2017-05-05 12:56 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-20 12:40 ` [Qemu-devel] [PATCH for 2.10 00/17] Block layer thread safety, part 1 no-reply
2017-04-20 12:42 ` no-reply
2017-05-02 15:42 ` Paolo Bonzini
2017-05-04 8:09 ` Fam Zheng
2017-05-05 13:01 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c7d16c-116a-3d28-8cc8-88f737ee7cc8@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).