From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9FD7C02181 for ; Fri, 24 Jan 2025 08:32:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tbF64-0005L5-59; Fri, 24 Jan 2025 03:31:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tbF61-0005JG-25 for qemu-devel@nongnu.org; Fri, 24 Jan 2025 03:31:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tbF5y-0003CS-8M for qemu-devel@nongnu.org; Fri, 24 Jan 2025 03:31:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737707475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ja2YEtYfegNBfk+N5lKXoAbuJe9KVtuC1iQhOhtaiCI=; b=Ip9I4bqwavJUlrno33u9lUYwHOgDaGhlQ7zwZCFuyAU9GCRLGm0ipeu5uaNifYOrS5VrIj qFYHxkMhELmp4+3gXQDp4AiSlyb1N2z466kdBEIu0RgsVHsNumjA9P5PctSfLYvrUf9xkK AxkpJjIeBaGT4AZGE/WuUn7jnEB0UGQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-4tBCT36QOpOFz1lGnxNw2g-1; Fri, 24 Jan 2025 03:31:13 -0500 X-MC-Unique: 4tBCT36QOpOFz1lGnxNw2g-1 X-Mimecast-MFC-AGG-ID: 4tBCT36QOpOFz1lGnxNw2g Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4359206e1e4so12851245e9.2 for ; Fri, 24 Jan 2025 00:31:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737707472; x=1738312272; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ja2YEtYfegNBfk+N5lKXoAbuJe9KVtuC1iQhOhtaiCI=; b=GtSfVHGGxg+ArABDo4CCOxAGxB6+J63roYFhiFR2tJzowzXSCQIiGZya4TRXpBk2nV 9c0nYYsqkDzU1vjUUInzNQa2c6gy04zqf92t78dR6+GEscDWwsfUq8rBnjzrUY4vMecX e7dz3oxH4+zXrDEdjFFra7FAv4H35DMN/B7ogEEW1oGOzB8T6QrONWenOKrE7AYTNUlo di4nEXgu8zAzCAOXlP9UDj1xq4H7il8DPLOb+s2UVw+YTolFFLp7vLafS64AYA2vgFfA G9ClETb9etnn8WUrZyObAyqTvUcec4IsChoeIZNF+5W+mPPxaPlFldSwmmuIaXyEdkCE Xz8g== X-Forwarded-Encrypted: i=1; AJvYcCURdzKaWXEoBPxU7MVwu2g2WNoGBAZhEJLg2z1qu1fe2Y2jNlbBkVKKS0d40E9KCcG0PHjK6LCYP/7+@nongnu.org X-Gm-Message-State: AOJu0YyOKWQGLqbJUoeC/IQqdV+is1vllVa0NM69JVPP60qLkIcY1iHO SwUPPBrK3guMiX6wHPOhKeasgTkq6a9gumWn+fT9Ha5fUbzuB10qVO+3K/u8oye2zljuukUOx6s MqrT4N6nEv3CQUMEr+bgCvoOR1ygGN7m4i+irEq2kKvftP2c1tuxp X-Gm-Gg: ASbGncuMvksQs7tK9LaWv38a9gh8EtbO5XOvdBVVguEqf441Q3w7YbFS7TwbsC4SzUF vtAKlWqClBMFAT8KMgIUzKPx6Q1MkXk9VnBqbJKxn3XhHg/l28jBm/leOnR3m5nrIWTGUaIO6cp pX8k2kYFEu2q+CB8ImYXQccLD2vAtVr8Fq5FDzYWqkZ67ge61QvcdPYfz/dIG62Nzjxiqr1oiSG fyKygIfJdHVXkBi/3iD7kel2xShZpmcIADsBMYjwVLfTCBM3uJXW69ewBC9GqIX6DznZzLupvKn c3swxIEcZzWvggtwOWYWtQzcLst7Lzhh X-Received: by 2002:a05:600c:3d96:b0:434:a26c:8291 with SMTP id 5b1f17b1804b1-4389143b5dbmr254362935e9.24.1737707471964; Fri, 24 Jan 2025 00:31:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5VW3dfhM+LNeKHKzItLwuol1tFBZ1byVfw+JsQdNzMdVYNx5/Irmcymc8vsezRj49Xc4Hqg== X-Received: by 2002:a05:600c:3d96:b0:434:a26c:8291 with SMTP id 5b1f17b1804b1-4389143b5dbmr254362615e9.24.1737707471615; Fri, 24 Jan 2025 00:31:11 -0800 (PST) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd57325csm18168385e9.34.2025.01.24.00.31.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jan 2025 00:31:10 -0800 (PST) Message-ID: <2308a2a6-e2b0-4e16-a3fe-089ce7824239@redhat.com> Date: Fri, 24 Jan 2025 09:31:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/5] hw/vfio/ap: notification handler for AP config changed event To: Rorie Reyes , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, jjherne@linux.ibm.com, borntraeger@linux.ibm.com, alex.williamson@redhat.com, thuth@redhat.com, akrowiak@linux.ibm.com References: <20250107184354.91079-1-rreyes@linux.ibm.com> <20250107184354.91079-3-rreyes@linux.ibm.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20250107184354.91079-3-rreyes@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.043, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/7/25 19:43, Rorie Reyes wrote: > Register an event notifier handler to process AP configuration > change events by queuing the event and generating a CRW to let > the guest know its AP configuration has changed > > Signed-off-by: Rorie Reyes > Reviewed-by: Anthony Krowiak > Tested-by: Anthony Krowiak > --- > hw/vfio/ap.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index 30b08ad375..533cadb2dd 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -18,6 +18,7 @@ > #include "hw/vfio/vfio-common.h" > #include "system/iommufd.h" > #include "hw/s390x/ap-device.h" > +#include "hw/s390x/css.h" > #include "qemu/error-report.h" > #include "qemu/event_notifier.h" > #include "qemu/main-loop.h" > @@ -37,6 +38,7 @@ struct VFIOAPDevice { > APDevice apdev; > VFIODevice vdev; > EventNotifier req_notifier; > + EventNotifier cfg_notifier; > }; > > OBJECT_DECLARE_SIMPLE_TYPE(VFIOAPDevice, VFIO_AP_DEVICE) > @@ -70,6 +72,18 @@ static void vfio_ap_req_notifier_handler(void *opaque) > } > } > > +static void vfio_ap_cfg_chg_notifier_handler(void *opaque) > +{ > + VFIOAPDevice *vapdev = opaque; > + > + if (!event_notifier_test_and_clear(&vapdev->cfg_notifier)) { > + warn_report("Event notifier not initialized"); I don't think this warning is needed. May be reverse the logic : if (event_notifier_test_and_clear(&vapdev->cfg_notifier)) { css_generate_css_crws(0); } Thanks, C. > + return; > + } > + > + css_generate_css_crws(0); > +} > + > static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev, > unsigned int irq, Error **errp) > { > @@ -85,6 +99,10 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev, > notifier = &vapdev->req_notifier; > fd_read = vfio_ap_req_notifier_handler; > break; > + case VFIO_AP_CFG_CHG_IRQ_INDEX: > + notifier = &vapdev->cfg_notifier; > + fd_read = vfio_ap_cfg_chg_notifier_handler; > + break; > default: > error_setg(errp, "vfio: Unsupported device irq(%d)", irq); > return false; > > @@ -175,6 +193,15 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp) > warn_report_err(err); > } > > + if (!vfio_ap_register_irq_notifier(vapdev, VFIO_AP_CFG_CHG_IRQ_INDEX, &err)) > + { > + /* > + * Report this error, but do not make it a failing condition. > + * Lack of this IRQ in the host does not prevent normal operation. > + */ > + warn_report_err(err); > + } > + > return; > > error: