From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBDOZ-00028M-Hx for qemu-devel@nongnu.org; Thu, 19 Nov 2009 15:14:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBDOU-00022P-E1 for qemu-devel@nongnu.org; Thu, 19 Nov 2009 15:14:22 -0500 Received: from [199.232.76.173] (port=34013 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBDOU-00021w-6u for qemu-devel@nongnu.org; Thu, 19 Nov 2009 15:14:18 -0500 Received: from mail.gmx.net ([213.165.64.20]:37260) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1NBDOT-0001VH-4O for qemu-devel@nongnu.org; Thu, 19 Nov 2009 15:14:17 -0500 Message-ID: <230A5820D3894A2AB1BD2A31DF4411A7@FSCPC> From: "Sebastian Herbszt" References: <1258657672-9897-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <1258657672-9897-1-git-send-email-weil@mail.berlios.de> Date: Thu, 19 Nov 2009 21:13:29 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Fix build for mingw32 on windows ($@ in macro) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , av1474@comtv.ru, QEMU Developers Stefan Weil wrote: > Make using mingw32 on windows does not preserve $@ in macros > when they are modified using this pattern: > target: macro += something > > This behaviour results in an error when QEMU_CFLAGS containing > "-MMD -MP -MT $@" is modified for compilation of source files > which use SDL: $@ will expand to nothing, -MT no longer has > the correct argument (it will take the next one from the command > line) and the build will fail or run with a wrong command line. > > The problem is fixed by using a new macro QEMU_DGFLAGS > which is not modified by a target rule. > > Signed-off-by: Stefan Weil Tested-by: Sebastian Herbszt