qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@citrix.com>
To: Anthony PERARD <anthony.perard@citrix.com>,
	qemu-devel@nongnu.org, Ross Lagerwall <ross.lagerwall@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory
Date: Fri, 9 Mar 2018 16:13:31 +0000	[thread overview]
Message-ID: <23202.45739.128643.206532@mariner.uk.xensource.com> (raw)
In-Reply-To: <23202.45661.318179.372531@mariner.uk.xensource.com>

Ian Jackson writes ("Re: [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory"):
> Anthony PERARD writes ("Re: [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory"):
> > This patch seems to remove the last users of
> > xen_xc_domain_add_to_physmap(). Can it be remove from xen_common.h?
> > 
> > With that:
> > Acked-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Have added a separate patch for that.

Wrong patch.  Gah!

>From 8794b90b82612665d1e3f9f96ab73579a271c3be Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Fri, 9 Mar 2018 16:08:55 +0000
Subject: [PATCH 3/5] xen: Remove now-obsolete xen_xc_domain_add_to_physmap

The last user was just removed; remove this function, accordingly.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 include/hw/xen/xen_common.h | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
index 2eed6fc..5f1402b 100644
--- a/include/hw/xen/xen_common.h
+++ b/include/hw/xen/xen_common.h
@@ -645,28 +645,6 @@ static inline int xen_set_ioreq_server_state(domid_t dom,
 
 #endif
 
-#if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40600
-static inline int xen_xc_domain_add_to_physmap(xc_interface *xch, uint32_t domid,
-                                               unsigned int space,
-                                               unsigned long idx,
-                                               xen_pfn_t gpfn)
-{
-    return xc_domain_add_to_physmap(xch, domid, space, idx, gpfn);
-}
-#else
-static inline int xen_xc_domain_add_to_physmap(xc_interface *xch, uint32_t domid,
-                                               unsigned int space,
-                                               unsigned long idx,
-                                               xen_pfn_t gpfn)
-{
-    /* In Xen 4.6 rc is -1 and errno contains the error value. */
-    int rc = xc_domain_add_to_physmap(xch, domid, space, idx, gpfn);
-    if (rc == -1)
-        return errno;
-    return rc;
-}
-#endif
-
 #ifdef CONFIG_XEN_PV_DOMAIN_BUILD
 #if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40700
 static inline int xen_domain_create(xc_interface *xc, uint32_t ssidref,
-- 
2.1.4

  reply	other threads:[~2018-03-09 16:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 19:02 [Qemu-devel] [PATCH v6.1 00/11] xen: xen-domid-restrict improvements Ian Jackson
2018-03-08 19:02 ` [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types Ian Jackson
2018-03-13 15:11   ` Paolo Bonzini
2018-03-26 13:58     ` Ian Jackson
2018-04-19 16:32       ` Ian Jackson
2018-03-08 19:02 ` [Qemu-devel] [PATCH 02/12] xen: link against xentoolcore Ian Jackson
2018-03-08 19:02 ` [Qemu-devel] [PATCH 03/12] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2018-03-08 19:02 ` [Qemu-devel] [PATCH 04/12] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson
2018-03-08 19:03 ` [Qemu-devel] [PATCH 05/12] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2018-03-08 19:03 ` [Qemu-devel] [PATCH 06/12] xen: move xc_interface compatibility fallback further up the file Ian Jackson
2018-03-08 19:03 ` [Qemu-devel] [PATCH 07/12] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2018-03-08 19:03 ` [Qemu-devel] [PATCH 08/12] os-posix: Provide new -runas <uid>:<gid> facility Ian Jackson
2018-04-13 15:51   ` Markus Armbruster
2018-04-16 14:06     ` Ian Jackson
2018-04-16 16:17       ` Markus Armbruster
2018-04-16 17:00         ` Ian Jackson
2018-04-16 18:06           ` Markus Armbruster
2018-03-08 19:03 ` [Qemu-devel] [PATCH 09/12] configure: do_compiler: Dump some extra info under bash Ian Jackson
2018-03-08 19:03 ` [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory Ian Jackson
2018-03-09 15:44   ` Anthony PERARD
2018-03-09 16:12     ` Ian Jackson
2018-03-09 16:13       ` Ian Jackson [this message]
2018-03-08 19:03 ` [Qemu-devel] [PATCH 11/12] xen: Expect xenstore write to fail when restricted Ian Jackson
2018-03-09 15:46   ` Anthony PERARD
2018-03-08 19:03 ` [Qemu-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file Ian Jackson
2018-03-13 15:11   ` Paolo Bonzini
2018-03-09 16:20 ` [Qemu-devel] [PATCH v6.1 00/11] xen: xen-domid-restrict improvements Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23202.45739.128643.206532@mariner.uk.xensource.com \
    --to=ian.jackson@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=jgross@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ross.lagerwall@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).