qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Greg Kurz <groug@kaod.org>
Subject: [PULL 2/8] 9pfs: simplify v9fs_walk()
Date: Mon, 05 Jul 2021 13:13:51 +0200	[thread overview]
Message-ID: <232a4d2c25c3a83e148116a15f992f728c3579e6.1625483630.git.qemu_oss@crudebyte.com> (raw)
In-Reply-To: <cover.1625483630.git.qemu_oss@crudebyte.com>

There is only one comparison between nwnames and P9_MAXWELEM required.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <E1liKiz-0006BC-Ja@lizzy.crudebyte.com>
---
 hw/9pfs/9p.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 0fa776af09..89aa07db78 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -1739,7 +1739,11 @@ static void coroutine_fn v9fs_walk(void *opaque)
 
     trace_v9fs_walk(pdu->tag, pdu->id, fid, newfid, nwnames);
 
-    if (nwnames && nwnames <= P9_MAXWELEM) {
+    if (nwnames > P9_MAXWELEM) {
+        err = -EINVAL;
+        goto out_nofid;
+    }
+    if (nwnames) {
         wnames = g_new0(V9fsString, nwnames);
         qids   = g_new0(V9fsQID, nwnames);
         for (i = 0; i < nwnames; i++) {
@@ -1753,9 +1757,6 @@ static void coroutine_fn v9fs_walk(void *opaque)
             }
             offset += err;
         }
-    } else if (nwnames > P9_MAXWELEM) {
-        err = -EINVAL;
-        goto out_nofid;
     }
     fidp = get_fid(pdu, fid);
     if (fidp == NULL) {
-- 
2.20.1



  parent reply	other threads:[~2021-07-05 12:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 11:13 [PULL 0/8] 9p queue 2021-07-05 Christian Schoenebeck
2021-07-05 11:13 ` [PULL 1/8] 9pfs: add link to 9p developer docs Christian Schoenebeck
2021-07-05 11:13 ` [PULL 7/8] 9pfs: drop root_qid Christian Schoenebeck
2021-07-05 11:13 ` [PULL 5/8] 9pfs: drop fid_to_qid() Christian Schoenebeck
2021-07-05 11:13 ` [PULL 3/8] 9pfs: fix not_same_qid() Christian Schoenebeck
2021-07-05 11:13 ` [PULL 6/8] 9pfs: replace not_same_qid() by same_stat_id() Christian Schoenebeck
2021-07-05 11:13 ` [PULL 8/8] 9pfs: reduce latency of Twalk Christian Schoenebeck
2021-07-05 11:13 ` Christian Schoenebeck [this message]
2021-07-05 11:13 ` [PULL 4/8] 9pfs: capture root stat Christian Schoenebeck
2021-07-05 13:57 ` [PULL 0/8] 9p queue 2021-07-05 Peter Maydell
2021-07-05 15:34   ` Christian Schoenebeck
2021-07-05 19:03 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=232a4d2c25c3a83e148116a15f992f728c3579e6.1625483630.git.qemu_oss@crudebyte.com \
    --to=qemu_oss@crudebyte.com \
    --cc=groug@kaod.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).