Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

[Helge Deller <deller@gmx.de>]

On 12/19/22 12:52, Peter Maydell wrote:
> On Mon, 19 Dec 2022 at 11:40, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> On 19/12/22 12:31, Peter Maydell wrote:
>>> On Mon, 19 Dec 2022 at 11:22, Helge Deller <deller@gmx.de> wrote:
>>>>
>>>> Hi Paolo,
>>>>
>>>> On 12/17/22 14:28, Paolo Bonzini wrote:
>>>>> These are wrong.  qemu-bridge-helper, virtiofsd, qemu-storage-daemon
>>>>> and qemu-keymap *are* tools; if they fail to build due to any
>>>>> dependencies, or due to other compilation issues, you need to add
>>>>> tests to meson.build and check for the cause of the issues.
>>>>
>>>> No doubt, those are *tools*.
>>>> But aren't those only required when you run system- and/or user-emulation?
>>>>
>>>> Looking at the packaging of qemu in debian:
>>>>
>>>> qemu-system-common debian package consists of thse *tools*:
>>>>      qemu-bridge-helper, vhost-user-gpu, virtfs-proxy-helper, virtiofsd
>>>>
>>>> qemu-utils debian package consists of the *utilities*:
>>>>      qemu-img, qemu-io, qemu-nbd
>>>>
>>>> IMHO this categorization makes sense.
>>>
>>> Possibly, but it's not the categorization we use upstream,
>>> which splits our binaries into three groups:
>>>    * system-emulation binaries (qemu-system-arm, etc)
>>
>> Subcategory:
>>
>>          * helpers (required to use system-emulation binaries),
>>            apparently provided by 'qemu-system-common' on Debian
>>            -- except virtiofsd which is not a helper --
>
> No, I don't think this is a subcategory. We provide
>   --enable-system
>   --enable-user
>   --enable-tools
> but there is no
>   --enable-helper
> and qemu-bridge-helper, etc are built via --enable-tools.
>
>>> (I think the guest-agent may be a fourth group.)
>>> ...
> No, it looks like we build it via --enable-guest-agent,
> and --enable-tools is not checked.

Given that info, would it then make sense to keep as is:
    --enable-system
    --enable-user
    --enable-tools -> qemu-bridge-helper, vhost-user-gpu, virtfs-proxy-helper, virtiofsd
    --enable-guest-agent -> guest agents  (option is there already, but not used)
and additonally add:
    --enable-utils  -> qemu-img, qemu-io, qemu-nbd

This would leave the helpers in --enable-tools.

Helge