From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7B8C35247 for ; Mon, 3 Feb 2020 18:13:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F24A20838 for ; Mon, 3 Feb 2020 18:13:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megamailservers.eu header.i=@megamailservers.eu header.b="mJnnZh3C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F24A20838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=o2online.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iygDb-0006X4-Lf for qemu-devel@archiver.kernel.org; Mon, 03 Feb 2020 13:13:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47641) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iygBE-0003Vi-Dz for qemu-devel@nongnu.org; Mon, 03 Feb 2020 13:10:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iygBC-00082O-5A for qemu-devel@nongnu.org; Mon, 03 Feb 2020 13:10:39 -0500 Received: from mail1441c50.megamailservers.eu ([91.136.14.41]:57978 helo=mail264c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iygB8-0007jV-L5; Mon, 03 Feb 2020 13:10:35 -0500 X-Authenticated-User: 017626146082@o2online.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1580748363; bh=MSzPDF9uLwq6F8ZOJIb0eJBBqDtvibTwL8H1wiozBjQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mJnnZh3Cfo3uBkvo56tSTW4ZaqeOAmyZT3KTLA4yqvllWBJoZJGhdqxfy9L4dOvN0 OMDRsOUYn2FlhTHa82jc5WgBvftcU/KDz0eQf4xwxXrWXEEZkDbdXXX5vSMVt92Xkv YZsUzvF+m9fylI8c5JfwupMFTQeZP295aDwVT0Ms= Feedback-ID: rsta2@o2online. Received: from desktop2.localnet (178-21-1-177.ilmprovider.net [178.21.1.177]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 013Gk1B2003653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 3 Feb 2020 16:46:02 +0000 From: Rene Stange To: Philippe =?ISO-8859-1?Q?Mathieu=2DDaud=E9?= , Peter Maydell Subject: Re: [PATCH v2 2/2] bcm2835_dma: Re-initialize xlen in TD mode Date: Mon, 03 Feb 2020 17:45:51 +0100 Message-ID: <2339387.VYhbCED7Bd@desktop2> In-Reply-To: <80ae5ce3-c58d-800c-4748-ea4842a6ff84@redhat.com> References: <5397138.k0qeMALlIp@desktop2> <80ae5ce3-c58d-800c-4748-ea4842a6ff84@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-CTCH-RefID: str=0001.0A0B0213.5E384E4B.0058, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ar3M9hRV c=1 sm=1 tr=0 a=oFQkuSNlBNCQRuITVo1IXg==:117 a=oFQkuSNlBNCQRuITVo1IXg==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=8nJEP1OIZ-IA:10 a=20KFwNOVAAAA:8 a=WzSNw9QI6yEul72EYEEA:9 a=34CKMIUG4oTmPNvu:21 a=EWH9Gj-z8SLf1cE_:21 a=wPNLvfGTeEIA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.14.41 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , qemu-devel , Andrew Baumann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe, of course you are right. I understand, what you mean. I'm a non-n= ative English speaker and I'm still learning. :) Yes, I agree. Peter, please make the change, if you agree with the patch. Thanks, Rene On Monday, 3 February 2020, 17:27:08 CET, Philippe Mathieu-Daud=E9 wrote: > On 2/3/20 4:40 PM, Rene Stange wrote: > > TD (two dimensions) DMA mode did not work, because the xlen variable > > has not been re-initialized before each additional ylen run through > > in bcm2835_dma_update(), which has been fixed. >=20 > "which has been fixed" confused me, because this current patch is fixing= =20 > it. Using present tense makes it easier to understand for non-native=20 > English speakers IMHO: >=20 > TD (two dimensions) DMA mode does not work, because the xlen > variable is not re-initialized before each additional ylen > run through in bcm2835_dma_update(). Fix it. >=20 > If you agree, maybe Peter (the maintainer who will take your patch) can=20 > make the change for you. >=20 > Reviewed-by: Philippe Mathieu-Daud=E9 >=20 > >=20 > > Signed-off-by: Rene Stange > > --- > > hw/dma/bcm2835_dma.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > >=20 > > diff --git a/hw/dma/bcm2835_dma.c b/hw/dma/bcm2835_dma.c > > index 667d951a6f..ccff5ed55b 100644 > > --- a/hw/dma/bcm2835_dma.c > > +++ b/hw/dma/bcm2835_dma.c > > @@ -54,7 +54,7 @@ > > static void bcm2835_dma_update(BCM2835DMAState *s, unsigned c) > > { > > BCM2835DMAChan *ch =3D &s->chan[c]; > > - uint32_t data, xlen, ylen; > > + uint32_t data, xlen, xlen_td, ylen; > > int16_t dst_stride, src_stride; > > =20 > > if (!(s->enable & (1 << c))) { > > @@ -82,6 +82,7 @@ static void bcm2835_dma_update(BCM2835DMAState *s, un= signed c) > > dst_stride =3D 0; > > src_stride =3D 0; > > } > > + xlen_td =3D xlen; > > =20 > > while (ylen !=3D 0) { > > /* Normal transfer mode */ > > @@ -117,6 +118,7 @@ static void bcm2835_dma_update(BCM2835DMAState *s, = unsigned c) > > if (--ylen !=3D 0) { > > ch->source_ad +=3D src_stride; > > ch->dest_ad +=3D dst_stride; > > + xlen =3D xlen_td; > > } > > } > > ch->cs |=3D BCM2708_DMA_END; > >=20 >=20 >=20 >=20