From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B56C04AAF for ; Tue, 21 May 2019 15:30:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 390B02173C for ; Tue, 21 May 2019 15:30:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oKFXGpsV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 390B02173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:55631 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT6iw-0000Lw-Fl for qemu-devel@archiver.kernel.org; Tue, 21 May 2019 11:30:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT6hL-0007nI-Vh for qemu-devel@nongnu.org; Tue, 21 May 2019 11:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT6hK-0001ZA-SQ for qemu-devel@nongnu.org; Tue, 21 May 2019 11:29:03 -0400 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:46602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hT6hK-0001Y9-L5 for qemu-devel@nongnu.org; Tue, 21 May 2019 11:29:02 -0400 Received: by mail-oi1-x241.google.com with SMTP id 203so13079775oid.13 for ; Tue, 21 May 2019 08:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to; bh=0ICV70e5DICv82DIyxeSUvxwtXkbT4fhk3xy1ydw4Xg=; b=oKFXGpsVl3TNoiKfZ0X5qSnmt2lMpywOoQPNiPLYoArSin9dFGGHoJBWmiw/qu8ojg 3X9V+c+MYBi/kIsM/d7pmjxYw5qMmAGPtL1JoLHkicsc9vqiAn+b55qeQtDc2/2CdvVT LGotC9q5ZI/hh9bCTlpL3rSMoyddtPdIni4eJau8JAHhjwwE0IgOcP0qm1HLLq5oPjHc 3YfD7pX6Hf/tEm+m6jjS/lfRZCP935xE3JrqYr+96sYlgNVvJ361SzyOewqx9rDCYYry DuyptHBSparrtygyBQm1a1ZENJiQG3VqtFm7f3NfBro/yNLmK+UkSueLjJT8QRvnGH7Z kxBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to; bh=0ICV70e5DICv82DIyxeSUvxwtXkbT4fhk3xy1ydw4Xg=; b=dqXmL21Ra7O3kwAh/hTqPM9zou8hQLg1Gwu0qikuyAljy00xzyZ3CoGFeveovCvFrx YxQgnOcshdo2TT56hLOUAl4cz3VA2OE57qBbroXbmzyOZVz/JX6KxNwao2nh25nh8TpZ WIndcGp04X1Y8ybP6aM0xkAvzp9dMoFHXXiTcflCwwFLh2n+CdwB/HieHUEUpifbuN14 RqlYVwtO+pfv9NLe/cGkD3mIRv6EDs0Sbzd2XMpY7exKv2ezjMW7O+EeQGMaaObKEcFS S0cH9ghePI+FvbJzbhjAlftxaIyyIqkmkKRKv27AgqbJmyU9PFHNNIPEX9uofJXfBDVK AaeA== X-Gm-Message-State: APjAAAVwQ+QPzsumbBgnSU//F791ynCU8gyzHZW3gU5SJn243C27uXV4 U5Eax+/A7IEuAVua4rNRBMg= X-Google-Smtp-Source: APXvYqy/h6IVWttImvVF6TJE56Ck4hvDBZibPzztaYS0h0BMcT5uS1zq4HB9XXP3HYOnsjBIw338UQ== X-Received: by 2002:aca:59d6:: with SMTP id n205mr1176866oib.2.1558452540585; Tue, 21 May 2019 08:29:00 -0700 (PDT) Received: from [192.168.1.96] (69-222-133-165.lightspeed.tukrga.sbcglobal.net. [69.222.133.165]) by smtp.googlemail.com with ESMTPSA id z12sm7204215otq.38.2019.05.21.08.28.59 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2019 08:28:59 -0700 (PDT) To: =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20190517224450.15566-1-jan.bobek@gmail.com> <87v9y5gvfq.fsf@zen.linaroharston> From: Jan Bobek Openpgp: preference=signencrypt Autocrypt: addr=jan.bobek@gmail.com; prefer-encrypt=mutual; keydata= mQINBFbeakcBEACzYOxOXdeT3Ns+5fdSqZFODAb3VXBKQ9DL7ooxLQRhvAx6rKXP/ZkBD7eg q8DJuvx6FbH227wpX+JZQawtolRJO+BTOuyU4ANPn3LGQHNtI78VhjafK7/Geb/9J6mTLl+P iS1EpLjKFbaLQboOaVVCPOHfLJOMNm5Ks9iHVKPQcUWUnroZdm55MIWjRw+wYGpmLD/R+FK/ Cm1fS3j+tu9VYFoEFZmwW//PYzmEtYHpwXA6dOWEd12cu2208/JcEHYBl0Z6Oga0xAk2OxU5 BOELuewGLuSiWik4z594GLVleC2NMnr3gUPl1y8ADrKzQwYmPgytIdsQ0tkV5rK9R1XTk03e ZLViYWJt5dgea+jGWcHPKPfLln53V4nCbwklGFLJQDMo8hL82bjJ7x9bsXoAnkPxJgYHgsM0 LCLewqEIN6khniNv/1vOAKnwoXywlIKsWrx/pFz4xXNLVHoLlkRUl1DeWWzuaha2xEsm0yfe QkntqMrHC0CkBFzM1/ZE8fj8JBMjMG8me93RK9mr03TV4aROgQfi4Pjy55VKal/WpVkD4tKo nTN0nHkPVsHfx+htN/+A3nnUFyfesE1wWdCxhqhIn8d/Aw9KqraYmbyTzRErXLadA4O0UmZZ yPyNWQhTgGfJ9r66S+CifsiHkHlzJ/9i9AcHeh6+rXs9gjk4YwARAQABtB9KYW4gQm9iZWsg PGphbi5ib2Jla0BnbWFpbC5jb20+iQJRBBMBAgA7AhsDAh4BAheAAhkBFiEETAzi4j5xV5X9 nNm0vpyriGq+2b4FAlwy32MFCwkIBwIGFQoJCAsCBBYCAwEACgkQvpyriGq+2b6NPw/9Fi+N vmxMd81Oh3hHUZlh8fNqcvXmHqnKHslJJG9M8CXkWcd1cF+sWX+lhi2Pvi4KA2Ng++NEpi6p sPrY9ZSPb4gAQYFgq6aXonnsrNSHeBMZI0E2mbK1YW4lYYJuMpqotBKqpgpoP9Fd8QbBR9vA Dm18fcDQFJP0vBmLY2TWo2tdqUH1X3z1xpdADpdjMZeQ+LrQ823Vi8ib0aanaR+gJ+20w7tn M+iTAGSz9jj+IAjDvrt6dpgwKaN+sFpqQFr0ClItDgtWWChIOEo7AVxK35jEHZnRpAbSvX3q WxETfA/1/UiDD67FQ5mwzTm95oYw+bN6jYpQgv9BkWeOhvVi63bcQ212B5w/YJ/WysriD2tp j/cTbVBgW2Al29fbeKyqdCr43yqR0ZyZcKuOKpwEtkF4xo3Z4ZR6x4uZewCjNirlwKDSI9sE w137DWzREIk7sd2kZrMnFAjVOTVic8fs+jCeohuy6Eq7l+lMCWsyJTcXSY3HHmXAgoQu8HRE uwQB0H5rTWn4Hz/2OtWlYHxHcqGwcUP3bdxqch001JwycoYJFnqM27whPussfxRK3i6d0CiX 8N1lwBb4ukIH8y5ZFmdhMA960aTGVpeew5fnzRveZj2Fn6kPZX7Z5t0eXpdl0sYyKvxPy/rP 9atlD0qdA7LSBksLIoSQ5EE+rfhAvSO5Ag0EVt5qRwEQAL1zSWDNDk5M7kPTRuonvez0WbBq Sl36BBKMSsAVT7L5TTksQH0T/5N7+vTIXlOTefP2KN+8uITUR7Ld2grjdcLIpx86ff4gVmuv P7Xc0wKd/dmDPVqEtBKbCPCtnHznZWUWe/zJNru9aE2RwumMjMzAqXX8VEzy+XSqToneX1a2 +k6+4ZRWvrJ5Kb+5vs+ccw5hQlWyF7vruUNLLVO9LgPD4BbIKyyhosuVp8PtJqdsz27eb3y0 oh4ThSwx+S7lYucUB30HUtqBWJ9gMiqmXDLEhx+3v5wxCWm0oko9nnwk0PstRkZ39WAawnix gpQ+3Gw32yFZaDOEbfbob2+Tyc3/NA7aTnllvK1ihXaHr7dzwbE96XSEsz1RPOl/Cn2cZ0gY 1/kMzUesBqrlyBIGl9TY/QLu3z2B/INwc/ZlN3oEIJRXhS0KvtUA8tT4NSXVz8yLLO7tQv/g tSP0B2jsZRhm3QReCJT/cNmlOJ3O7b835Vpd+QbFoyCbKRcT6dVHl+Ay5UZykihg45HXDwtl FRgYUh7xJuxHnF8SDMlPcFqdOocPXq/fgfbxDFhLOFIj/qzEI892wu5lxfDGn9u8KCZ8p55N YSlcLOYlvDfCr5/syBWqO928XMOXdmQqhUFsP2aV0L3pL35qh7kfsAdSN4S0KgdQq4DUe8Mf +GXaHyIVABEBAAGJAjwEGAECACYCGwwWIQRMDOLiPnFXlf2c2bS+nKuIar7ZvgUCXGyXZwUJ By12uwAKCRC+nKuIar7Zvj4mEACW5/tViY+6MMv4Qh7zCXTmyNOepFjaSdbeBXpgL6IHbO3y kH5K90vCGl8rgQvIxOnX5cj/o1/y8NnfJ+lv94Hlqg9DkDHt4V2Zu570gIs81dlhxOqjZh/h 14LLigmx699j6ZfpRksuGKS07/3ZomrBBsMTzK+44+BXX1zLBqSamwD038TAq8n9DwILAVma 5C814/i1OciQz2HhK6QH8hMFMtX/8E//B6Q5oy9GPjrznYy+Wq52cmrwX7asqTkJ8q+oryaO I/popEdiE2boPz2KTa2fti2otyhU7Qc1iTdvIoUxyXZtQP7bI5RspvGHk6IP+5ksOdBjG6D6 IifJ1gw7cHip1mxz75uFb52jscIjkdSDhveAiSqnwAlMBy/UD2QVwTTL2o34jXwofkK+I20S J5kDhUuqYrsD4zMGHX/PWa7w7oeUU3cHejj0KI6MrN6LdvYPckycglZbS2AKUd82m6XES8gA 2pVPSjTH8BQKQ/Bbdgt7X416igU0nfpuj5aXe3NuLSO1sJbYRGFERTkUgxZm/RpRytGL4SPt PQUBJBl8uNYwyN5Y19lwsghGFPeYeTgcPsaEf6YsLVwozZBId4WNDAaVgnxibxH4Xjb6JkwJ 2W9jjN3tvmY+O0w1rnvRIJ99Btq6Qls7Nj+tdDDEKhufxpRrHTmwBUuLN+zZ9LkCDQRcbJZM ARAAvczli16jbnLXksVpMj0Z8JRiIdJvE23xofalA4R+Y5oKrK+mcpTUcb+XIdkArrQNQQtq pgPHLI5Dn4urmgs4E9KlBe+4fQBIzP0jyx8wH1MjhGak9QQXpLL5Z6evUdhjuyIoAb5rUgOb yl+wu9vmIYsJD4HzYul+nQkx/RxTZ3/OUN5JamL7AoAL5dHKOSpEUqRHq7ZoNqn6OGDxRInX dgnSs0SDYVAKVK7B8iFhEmdFXN25jOXLAtwtAh9cVGISfjEQftlvnoLQ6g+UbJ0XMWr6Y8pf mfOXPEoP9takIlhoZqxFiJ98lHtbkJ2u0hDTuAYe+HxBZT16bcCsucSITC6h3qQJTMxJgQ0C 5fA23ZUA9l4RszA7Lb6/wxIzko2jzZDbMaK8tsX5hHn7pJoPA34w3sY9hocMn707PWcxVVYf zl9YL3cAqcbD3hMTi3v+ukw7ArQ8sKaSYMBBC9GH54ePmiLpJ3wOsgNxxeIVvnCjVwMms8Br fLfnV+kuB0GABOOCsVXLkS73VjpouDzZ9k7SuZ+wVPZbJfgqLIHOT/j2nyVYVQCmzZ733E2c 1/Qywe2hUfZz5NWg4fFiFywBGqcHCoeMjDuZgJ6VRMxtfAQhC3FWoLrcQYhY3l1MvNToIm6M 4quvsQcJ6CMnVxpu1ULAhSkpmTvsH0BCjWeYLBEAEQEAAYkEcgQYAQoAJgIbAhYhBEwM4uI+ cVeV/ZzZtL6cq4hqvtm+BQJcbJqwBQkBn0q2AkDBdCAEGQEKAB0WIQRI9g6q0xHepFmsS61l 6DaV2uM2zwUCXGyWTAAKCRBl6DaV2uM2z0m3D/9ebunqJVHvk1pIiJ29GfzXqUIVCyG3aXyG T0RwXrQ9mKil+6/zLvAWh9NeksSIqKFDCQkC55WTUd1jL/lpDdipLo32BBLG+N0L40Nab1dM QldolDWocwmJuD99bWJmd0bkmVGCLDiXVgOyec8BFggixnqVEvrz7Sh0lP9tnsb4BE7v63Q0 q8uFt+n3swBvMnbjbNs2uGCyRz4f0tasF3Dd3R+08LZydrarJ15C0Smqghjald8UmJNi7uvI ZVwcEHSt6imp9gd4uAtcis8ebXkwAkWhW/n5DCpNVlZ8ve3haA767SJCuf4eIcPLIwW9KcgE nZ3zQPqclkd9TEmttIxk7C/MoRjxNC+gkyAMQXksxPIDVutythS8JVacMSaDshFtO0RiZ/mH e4oGdsBcRhThM923M9iMZAM1XLQpd5Pe+VhDsDN3+QXwkDH88t7tocamj/Ew5UT8qmZy7BJt vtDPeybOgxgiVDTlvEARUHK20UiLa7l8HEnJNInlSjakch6MF6axI1Ye81Ahc/snl5PP1gYl lmoQkJlRPTYgH/NLtRqcECff5pjOtUEoWWXrxRSKc0QRsTT5DhC4Z2CX3p6k0RDeMvZJnbyV geYWFyT5YBPvZBf0meL541JsfvTpOhcfdk//2RvMsyxNaGeemvWQEJKg/C/fTH3So3pEmPkE GwkQvpyriGq+2b6xKw//ToIcWJv1S+COsfuCZLTPL0f80pIr7yFYGcOcEfhbkdoZHAcWZP/X 50NeUuSOYGoT6+pU6a6lvycB7JTuAHuSIHo8HpIPF+sju14FN47Yd1n9akW89HLeSzR5paw3 g9FD1TbK9uFmK+bxMREAj1Gtd7qcummK6ArpjkEdOjwPXBz9n1iVo/Jgq11Mbhg8TYCP8WRw 8Lv+znH/cTSTgDxM92S79wDuFoO50zhlWzPa/g2prrUIxJxs74uBEGYy8LulRv25MfdQJVAY YE6+HYAJL6S/ko2m6XCr3hLsnD0kXamzvpJtDhbgBcXDd05XDjEFurZTOWv+thwVb+BAedhP XrH9DQ7/VUQBHnXz1ts5NYMjBI5NC1d16DYPtkCY0N9Jcv+fyJlAYpS7PHlZsyZmK7uUbm6p xRARxxjf+U86NTBAtdnDIO/NYxhX587vXuTm2pA2pnkKYTK74QLc/ys6rO3Cwo2QSFkxx3UZ uD1PmEfcmmfqPmuv037Dzpe5hYj5csGsdNLMLSK1WZqaAhBAtCnh3Rme71Je7f+eObRAHHGZ sftsaIi3kpdIyUnKybZhViIlXs8Cde5O2HCI0NhHnaDnxKdmHaIZVlH1hX3koaRrWCeGjts1 WWOVGHwSUSJ3lpUXEBHBicrX3bH/vUVTNTnwzGLSf/23VC9WYAe69II= Message-ID: <233da7c2-baed-face-16e8-af7a06d642c5@gmail.com> Date: Tue, 21 May 2019 11:28:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87v9y5gvfq.fsf@zen.linaroharston> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IhT2JHwULx4mVgtMg6WGWY0AyYbURZl8x" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::241 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [RISU v2 00/11] Support for i386/x86_64 with vector extensions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IhT2JHwULx4mVgtMg6WGWY0AyYbURZl8x From: Jan Bobek To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: qemu-devel@nongnu.org, Richard Henderson Message-ID: <233da7c2-baed-face-16e8-af7a06d642c5@gmail.com> Subject: Re: [RISU v2 00/11] Support for i386/x86_64 with vector extensions References: <20190517224450.15566-1-jan.bobek@gmail.com> <87v9y5gvfq.fsf@zen.linaroharston> In-Reply-To: <87v9y5gvfq.fsf@zen.linaroharston> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/20/19 8:30 AM, Alex Benn=C3=A9e wrote: >=20 > I'm not sure where my test went wrong but I guess it's around xfeatures= =2E > The code says required argument but risu doesn't seem to stop me not > specifying it. I suspect we should default to the most minimal x86_64 w= e > can and explicitly enable extra features. The argument is indeed required, that's taken care of by getopt: to test that, one can simply specify --xfeatures as the last option on the command-line. However, we don't check if the value successfully parses into an integer; is it at all possible that --xfeatures inadvertently swallowed the next part of your command-line? I shall add this check in v3. In any case, we currently default to SSE; this seems reasonable given that it's an extension dating back some 20 years and pre-dates x86_64 by 4 years (1999 vs. 2003). Opinions? > Storing xfeat in the stream is a good idea so people don't mix up their= > dumps but we probably need more validation when running in master mode > that the feature you have enabled is actually available on the > processor. Otherwise you'll potentially end up generating test streams > on HW with no support and just get a bunch of undef noise ;-) Correct me if I'm mistaken, but I believe this should be enforced by xsave_feature_buf. There's a call to __get_cpuid_count to retrieve location of a given XSAVE feature in memory, which is asserted to complete successfully. I assume if the feature were not present, the assertion would fail. I guess there's a point to be made about release builds, in which the assert may have been optimized out; shall I turn it into an error message instead? > However the series is looking pretty good so far. Looking forward to th= e > next iteration. Once again, thanks a lot for the review, Alex! -Jan --IhT2JHwULx4mVgtMg6WGWY0AyYbURZl8x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEESPYOqtMR3qRZrEutZeg2ldrjNs8FAlzkGToACgkQZeg2ldrj Ns8yohAAloRa0SIruL4/on6MTiaje8QtBAdHLHlEZHvJqIhbSigk+uWOpTbsJ3gN YQpMQ/cyYtlGIsLmKZgD7FT8F9oaTggkCaq5cm0KiUekkSt6fgVvPRX1fdncwZe/ biNsYIaVzWJy3cOutuj4IIZkhxTdy7vWT2e9OE+yLph2DYF8XvVV2q0KxuHxP1cb FYr100EncRD8mJmv0srVmiDNfjPy7dGJ0LPwaHz+LD7D/AobqbqyoGn0J5pX7RMp C4C7BK6460bJDPJEBumKd25KhRLYGA+JXaOGu0uqZ6AXo39Bx2DcJyALW0pk6aHh 3QWUcMB+YnrnItyVOKRTDfACycfgsAdoXfNvDs+qZwfFUZ8FATZTOobyBjLF1uxK uXu6M5Bz4Y7ULh0kxmU/3zK+sVhsm8tn7G6YP125GRsmIl89crBoa26+sPpWb4Tg VhSJ83W6r3fbJZsP0YuZ54R8HaFsH2WiP0fjUHy6eCj3Wk7I2YP+cfoddS/4JZJT 5Zeh2FBEurZRW3NXVxxt3GjkBHbQg3eApAg5jBJcW0HJifCOS9OIhLoIx/LLRA/H x9AiRaoKWNG0rK2r+0yzKpTUSwQS/HVsevMjRA9PyvbvGR6Zjd4DISZRDJmVfSje 8Xe+owxdAlpwOj61UsQZu0DoQL5zZFh8+VFqIiCH3yVhe5FpuB8= =xoIj -----END PGP SIGNATURE----- --IhT2JHwULx4mVgtMg6WGWY0AyYbURZl8x--