From: Paolo Bonzini <pbonzini@redhat.com>
To: roysh@mellanox.com, Stefan Hajnoczi <stefanha@gmail.com>
Cc: roy.shterman@gmail.com, pl@kamp.de, qemu-devel@nongnu.org,
ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU
Date: Tue, 27 Sep 2016 13:52:40 +0200 [thread overview]
Message-ID: <23477b74-e93a-923f-b83f-bf13fc255b3f@redhat.com> (raw)
In-Reply-To: <0537c2f5-39a7-2835-8f45-c7b43afcc50c@mellanox.com>
On 27/09/2016 13:37, Roy Shterman wrote:
>>>
>>> + iscsi_url = iscsi_parse_full_url(iscsi,
>>> uri_string_unescape(filename, -1, NULL));
>>> if (iscsi_url == NULL) {
>>> - error_setg(errp, "Failed to parse URL : %s", filename);
>>> + error_setg(errp, "Failed to parse URL : %s",
>>> uri_string_unescape(filename, -1, NULL));
>> uri_string_unescape() returns a newly allocated string. This is a
>> memory leak!
> will be fixed in v3
>>
>> Is unescaping a bug fix? Please put it into a separate patch.
> because libvirt is parsing '?' char as %3F, I needed to parse to URI
> with unescaping.
This looks like a libvirt bug. But if libvirt learns to pass iser://
URIs, the unescape is not necessary, is it?
Thanks,
Paolo
next prev parent reply other threads:[~2016-09-27 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 18:19 [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU Roy Shterman
2016-09-21 18:23 ` no-reply
2016-09-27 10:28 ` Stefan Hajnoczi
2016-09-27 11:37 ` Roy Shterman
2016-09-27 11:39 ` Peter Lieven
2016-09-27 11:52 ` Paolo Bonzini [this message]
2016-09-27 11:58 ` Roy Shterman
2016-09-27 12:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23477b74-e93a-923f-b83f-bf13fc255b3f@redhat.com \
--to=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=roy.shterman@gmail.com \
--cc=roysh@mellanox.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).