From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51130)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1boqxe-0006q3-EE
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 07:54:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1boqxZ-00081Y-GJ
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 07:54:09 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:35661)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1boqxZ-0007wq-AJ
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 07:54:05 -0400
Received: by mail-wm0-f67.google.com with SMTP id b4so775738wmb.2
	for <qemu-devel@nongnu.org>; Tue, 27 Sep 2016 04:53:43 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1474481984-10452-1-git-send-email-roysh@mellanox.com>
	<20160927102813.GE563@stefanha-x1.localdomain>
	<0537c2f5-39a7-2835-8f45-c7b43afcc50c@mellanox.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <23477b74-e93a-923f-b83f-bf13fc255b3f@redhat.com>
Date: Tue, 27 Sep 2016 13:52:40 +0200
MIME-Version: 1.0
In-Reply-To: <0537c2f5-39a7-2835-8f45-c7b43afcc50c@mellanox.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in
 Libiscsi-QEMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: roysh@mellanox.com, Stefan Hajnoczi <stefanha@gmail.com>
Cc: roy.shterman@gmail.com, pl@kamp.de, qemu-devel@nongnu.org, ronniesahlberg@gmail.com



On 27/09/2016 13:37, Roy Shterman wrote:
>>>
>>> +    iscsi_url = iscsi_parse_full_url(iscsi,
>>> uri_string_unescape(filename, -1, NULL));
>>>       if (iscsi_url == NULL) {
>>> -        error_setg(errp, "Failed to parse URL : %s", filename);
>>> +        error_setg(errp, "Failed to parse URL : %s",
>>> uri_string_unescape(filename, -1, NULL));
>> uri_string_unescape() returns a newly allocated string.  This is a
>> memory leak!
> will be fixed in v3
>>
>> Is unescaping a bug fix?  Please put it into a separate patch.
> because libvirt is parsing '?' char as %3F, I needed to parse to URI
> with unescaping.

This looks like a libvirt bug.  But if libvirt learns to pass iser://
URIs, the unescape is not necessary, is it?

Thanks,

Paolo