Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

On 09/17/2017 09:43 PM, Fam Zheng wrote:
> This will be used by setup test user ssh.

Shouldn't the commit message have more details about WHY we are checking
in a private key? The conversation last time included useful gems such as:

Some guests require the key to exist prior to provisioning the guest,
and reusing a pre-built key avoids consuming entropy every time the
testsuite is run.  Because the private key is well-known, care must be
taken to use the key ONLY in situations that cannot be compromised by
external network clients.

> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/keys/id_rsa     | 27 +++++++++++++++++++++++++++
>  tests/keys/id_rsa.pub |  1 +
>  2 files changed, 28 insertions(+)
>  create mode 100644 tests/keys/id_rsa
>  create mode 100644 tests/keys/id_rsa.pub
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]