From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxbmW-000638-Gk for qemu-devel@nongnu.org; Fri, 21 Oct 2016 11:30:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxbmV-0003XP-J1 for qemu-devel@nongnu.org; Fri, 21 Oct 2016 11:30:52 -0400 From: Pino Toscano Date: Fri, 21 Oct 2016 17:30:39 +0200 Message-ID: <2365877.PbZSkETgfu@thyrus.usersys.redhat.com> In-Reply-To: <20161021120221.GK11243@redhat.com> References: <1477048571-29592-1-git-send-email-ptoscano@redhat.com> <20161021120221.GK11243@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2445946.DBfeCZSlgY"; micalg="pgp-sha256"; protocol="application/pgp-signature" Subject: Re: [Qemu-devel] [PATCH v2] ssh: switch from libssh2 to libssh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, jcody@redhat.com, kwolf@redhat.com, mreitz@redhat.com --nextPart2445946.DBfeCZSlgY Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, 21 October 2016 13:02:21 CEST Richard W.M. Jones wrote: > On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote: > > Rewrite the implementation of the ssh block driver to use libssh instead > > of libssh2. The libssh library has various advantages over libssh2: > > - easier API for authentication (for example for using ssh-agent) > > - easier API for known_hosts handling > > - supports newer types of keys in known_hosts > > > > Kerberos authentication can be enabled once the libssh bug for it [1] is > > fixed. > > > > The development version of libssh (i.e. the future 0.8.x) supports > > fsync, so reuse the build time check for this. > > > > [1] https://red.libssh.org/issues/242 > > > > Signed-off-by: Pino Toscano > > --- > > > > Changes from v1: > > - fixed jumbo packets writing > > - fixed missing 'err' assignment > > - fixed commit message > > This version works, but I also switched from using a remote server to > using this over localhost. Could you please give it a try with the remote server case as well? > It seems as if the timeout might be a bit short. Could that be made > controllable? Or increased to match whatever libssh2 was using? Which timeout are you referring to? Thanks, -- Pino Toscano --nextPart2445946.DBfeCZSlgY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYCjSfAAoJEMPRTC2YZDfNF88P/ih3kItQcfBY0IMSBpFe48/M E+sXCSr/pSDcrnNbs3KpuMr7+y6bpAdk7dr1WRs8mz+z5Wn452XY1RFmoRVn/ia3 SBISdoAcAcAeF9kQ8Z84TD92eYO5mJiy1IT6O+7EzbR5XvbkboCQnY3hm7KiZ1D1 n5xjPuCSIgKLQmxgA8UZ2CptLudRHXHGFV0atsgmqb7ONeWlK2gxHH3a7Okcp65r EAoedisQpDT/slmk912a3vEZNCY460MxLBlyabPOG8wozzWMUCA5yWBjZHqiqU2h GggiS2t8rn9U6dkHBh2V5l3ZbyCYc6kgaBoi5m88wm4sF159Bo9dMDvnWzx33OmB tEP4YngISAN4NNwapXAOQAfCyhnRGq5ezfR0kArO/NxUlYcbaSQEaCcqr22x9ll2 npLkD1c4o8mUefVg3NdphRQaStiAtKFDEo3pBOw1N8018NRtFTvHT/RMIsk6bUkP hmRz6ve6U3q/lhEZaV9zKb5UEjqXdaNMHa3XHmUdFqnjry4epy8fGf6QXiK31CGT Te0DlSxbTiqCHBAmcjEc9t61lQ7mE63Dhh2eb+krKBlNbRz7ONvR8fjhorT2BLlT xCAd5AFdljAopu3f+7I9a2SuMd8XCv82GLWPDgaqtkZy1p1cjaeAdFRnAlcpcxVt FJq/6yWddpezGU4ae2KV =1MIP -----END PGP SIGNATURE----- --nextPart2445946.DBfeCZSlgY--