Re: [PATCH v36 17/17] target/avr: Update MAINTAINERS file

[Cleber Rosa <crosa@redhat.com>]

----- Original Message -----
> From: "Aleksandar Markovic" <aleksandar.m.mail@gmail.com>
> To: "Michael Rolnik" <mrolnik@gmail.com>, "Cleber Rosa" <crosa@redhat.com>, "Eduardo Habkost" <ehabkost@redhat.com>
> Cc: qemu-devel@nongnu.org, "richard henderson" <richard.henderson@linaro.org>, philmd@redhat.com, thuth@redhat.com,
> dovgaluk@ispras.ru, imammedo@redhat.com
> Sent: Monday, November 25, 2019 6:49:40 PM
> Subject: Re: [PATCH v36 17/17] target/avr: Update MAINTAINERS file
> 
> On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com> wrote:
> 
> > Include AVR maintaners in MAINTAINERS file
> >
> > Signed-off-by: Michael Rolnik <mrolnik@gmail.com>
> > ---
> >  MAINTAINERS | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5e5e3e52d6..ad2d9dd04a 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -163,6 +163,15 @@ S: Maintained
> >  F: hw/arm/smmu*
> >  F: include/hw/arm/smmu*
> >
> > +AVR TCG CPUs
> > +M: Michael Rolnik <mrolnik@gmail.com>
> > +S: Maintained
> > +F: target/avr/
> > +F: hw/misc/avr_mask.c
> > +F: hw/char/avr_usart.c
> > +F: hw/timer/avr_timer16.c
> > +F: hw/avr/
> > +
> 
> 
> If Cleber and Eduardo don't object, please add file:
> 
> tests/acceptance/machine_avr6.py
> 
> to the list. This means that the file would have a sort of "dual"
> maintainrship: Cleber and Eduardo would take care of Python/Avocado/test
> harness aspects, while you and Sarah would take care of AVR aspects.
> 

No objections, quite the contrary, I'd happy to be CC'd when such code
changes.

Thanks,
- Cleber.

> Cleber and Eduardo, please note that AVR target will be significantly
> different than others, since these CPUs are not meant to work with Linux
> kernel, and there are other idiosyncracies where AVR folks would be really
> needed. There is also a case of MIPS-specific Avocado test where, at least
> from my point of view, dual maintainership worked well, so I think this one
> would work well too.
> 
> With or without that file addition:
> 
> Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> 
> 
> 
> >  CRIS TCG CPUs
> >  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> >  S: Maintained
> > --
> > 2.17.2 (Apple Git-113)
> >
> >
>