From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E850CCF9E5 for ; Mon, 27 Oct 2025 14:29:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDODU-0001XV-Gu; Mon, 27 Oct 2025 10:29:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDODS-0001Wu-BS for qemu-devel@nongnu.org; Mon, 27 Oct 2025 10:28:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDODN-0006Jp-16 for qemu-devel@nongnu.org; Mon, 27 Oct 2025 10:28:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761575327; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q4+oj4RF7lNjQEMmYfNeix7T+L5tROC8e7rGvjg4KYw=; b=JuuZI1TXRNSwneFTdv13JWScZ2jQCEydqTh4TXemYcKxDfyOnavx83O1gcSFCJfooojmh1 INQcumQf7mbcUwnlr2mHZIOp4SYojA/YAMqTg8g/NLLu7++Kvm0rjmVU3ekOHqYDr3m14n 3y56bgyLwUAyDFfQhGyhljMuVJiXMgA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-31QaHLX-P5yjcvonZ73FfA-1; Mon, 27 Oct 2025 10:28:41 -0400 X-MC-Unique: 31QaHLX-P5yjcvonZ73FfA-1 X-Mimecast-MFC-AGG-ID: 31QaHLX-P5yjcvonZ73FfA_1761575320 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-426d4f59cbcso3688865f8f.1 for ; Mon, 27 Oct 2025 07:28:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761575320; x=1762180120; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q4+oj4RF7lNjQEMmYfNeix7T+L5tROC8e7rGvjg4KYw=; b=TTly1MP8kZtNyrhEBZh1YqaWUfg1ggXE/RdQp8A0NRXZMMHP62NWfBQWADelmEKTqa YEzhO2pobGYPIYI4tGZQPr/WUJYuK5pL8cILP7n2okl0pNL8nB5gGLTIVs94r0tEnSRY R6O0NZVvXwQhlc0xFPFVg0rfX1qCMicV4kz7WSyF+TWIxu+NQEC+2R/SspyvoNqK/FLB 9wCAZkUut3eMvpj7dyOU8+hv8gXoE6qgk/YmaFshVah4Z7PfEjTXBViGQlkF8T+lriqm kFI0eJupR53ar3zSdpkp+IC84Cjgz5mHrMVKof4UJW3L1F8Te/mQWtbhRbrnqy+qF4wf P7Ng== X-Forwarded-Encrypted: i=1; AJvYcCUz6CJlch6g185/UwOgaYbOSdb6lNFuaKkMcu6up6qUSYbEAiU7KmabGt5rbQ3kGMaGjM/Bu511kT1l@nongnu.org X-Gm-Message-State: AOJu0YxOpj/FwRPfmvPZyHPY3Qs0Wq7rRJtBRUvlC6Ig8Yg8h4fMOqfB X0kRLb9ntlLFmFJG8pCg6NYXubJCSfGfWa5IJMhFJu7SXtrX1i+wps7D7IKXmlo5fy2ZqB7y4VY qHK3iGXuJh55dl2aRqnAuGh2ckYJnPeekabA1E2oZNOFKm1TQG9qwdgVe X-Gm-Gg: ASbGncvzKsj7EXjuaOE9e5R0FUTogw3soeB8cIegRrzG2qq+axVsRE4hiLabSfsNjpP gIxXU5vwXGF+8mjT4jbSqrGN4IDXH9UVFAVmfPSTBDIO7bEpecq9yVEDGFnQvMEUmTSeD4MkzsV MqqtTkgALzpDZkUiHYWLuKdnBEdqVsJQd3uQtsk7+5RFKwGhFhtftqFS7t25BEl83+zyQn2S/2R +wlMjDYdjSSvkFrBfkBA3ZfFVixayREK78NEuUOyZ1Rho1KqUWoF1ABLRdPSfFL6e7k74+XDOBS Tei3DT6nQPu+uSOl77AXjXTa84CwNilvK1tsIE3ALsAdN5SOIFCy64JLYM9hMLFY8o/ikUf3l+5 21bZilEnumY760tUumdeGiIVSmJMSzNMngVyQI2IYkbQVxw== X-Received: by 2002:a05:6000:2889:b0:429:8b81:5ace with SMTP id ffacd0b85a97d-4298f524747mr10425448f8f.7.1761575320430; Mon, 27 Oct 2025 07:28:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbtJ6M7YWlvGTI6v01WaD3B/yhhPZCbLU2kCCJd6Y4IFSLl5K6DGThwW6QpxjUIxjZF35BLg== X-Received: by 2002:a05:6000:2889:b0:429:8b81:5ace with SMTP id ffacd0b85a97d-4298f524747mr10425423f8f.7.1761575320075; Mon, 27 Oct 2025 07:28:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:f0e:9070:527b:9dff:feef:3874? ([2a01:e0a:f0e:9070:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952df62dsm15794354f8f.45.2025.10.27.07.28.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 07:28:39 -0700 (PDT) Message-ID: <236ab7f6-3296-4ea4-80a8-a1d7bf08c73a@redhat.com> Date: Mon, 27 Oct 2025 15:28:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 20/27] hw/arm/smmuv3: Add accel property for SMMUv3 device Content-Language: en-US To: Nicolin Chen , Shameer Kolothum Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, peter.maydell@linaro.org, jgg@nvidia.com, ddutile@redhat.com, berrange@redhat.com, nathanc@nvidia.com, mochs@nvidia.com, smostafa@google.com, wangzhou1@hisilicon.com, jiangkunkun@huawei.com, jonathan.cameron@huawei.com, zhangfei.gao@linaro.org, zhenzhong.duan@intel.com, yi.l.liu@intel.com, shameerkolothum@gmail.com References: <20250929133643.38961-1-skolothumtho@nvidia.com> <20250929133643.38961-21-skolothumtho@nvidia.com> From: Eric Auger In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/16/25 11:48 PM, Nicolin Chen wrote: > On Mon, Sep 29, 2025 at 02:36:36PM +0100, Shameer Kolothum wrote: >> Introduce an “accel” property to enable accelerator mode. > Looks better with ASCII quotation marks: "accel". > >> Live migration is currently unsupported when accelerator mode is enabled, >> so a migration blocker is added. >> >> Because this mode relies on IORT RMR for MSI support, accelerator mode is >> not supported for device tree boot. >> >> Signed-off-by: Shameer Kolothum > Reviewed-by: Nicolin Chen > >> @@ -67,6 +67,7 @@ struct SMMUv3State { >> /* SMMU has HW accelerator support for nested S1 + s2 */ >> bool accel; >> struct SMMUv3AccelState *s_accel; >> + Error *migration_blocker; > No need of double space. > With Nicolin's comments: Reviewed-by: Eric Auger Eric