From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, hreitz@redhat.com,
marcandre.lureau@redhat.com, peterx@redhat.com, farosas@suse.de,
pbonzini@redhat.com, richard.henderson@linaro.org,
qemu-block@nongnu.org
Subject: Re: [PATCH 3/6] block/vmdk: Improve error messages on extent write error
Date: Mon, 13 May 2024 16:23:37 +0200 [thread overview]
Message-ID: <236fa43a-bb2a-4d10-89a8-bc70bb9f406b@linaro.org> (raw)
In-Reply-To: <20240513141703.549874-4-armbru@redhat.com>
On 13/5/24 16:17, Markus Armbruster wrote:
> vmdk_init_extent() reports blk_co_pwrite() failure to its caller as
>
> An IO error has occurred
>
> The errno code returned by blk_co_pwrite() is lost.
>
> Improve this to
>
> failed to write VMDK <what>: <description of errno>
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> block/vmdk.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-05-13 14:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 14:16 [PATCH 0/6] error: Eliminate QERR_IO_ERROR Markus Armbruster
2024-05-13 14:16 ` [PATCH 1/6] block: Improve error message when external snapshot can't flush Markus Armbruster
2024-05-13 14:24 ` Philippe Mathieu-Daudé
2024-05-13 14:16 ` [PATCH 2/6] dump/win_dump: Improve error messages on write error Markus Armbruster
2024-05-13 14:22 ` Philippe Mathieu-Daudé
2024-05-13 14:48 ` Markus Armbruster
2024-05-13 14:55 ` Philippe Mathieu-Daudé
2024-05-13 14:17 ` [PATCH 3/6] block/vmdk: Improve error messages on extent " Markus Armbruster
2024-05-13 14:23 ` Philippe Mathieu-Daudé [this message]
2024-05-13 14:17 ` [PATCH 4/6] cpus: Improve error messages on memsave, pmemsave " Markus Armbruster
2024-05-13 14:27 ` Philippe Mathieu-Daudé
2024-05-13 14:45 ` Markus Armbruster
2024-05-13 14:58 ` Philippe Mathieu-Daudé
2024-05-27 10:41 ` Markus Armbruster
2024-05-13 14:17 ` [PATCH 5/6] migration: Rephrase message on failure to save / load Xen device state Markus Armbruster
2024-05-13 14:24 ` Philippe Mathieu-Daudé
2024-05-13 18:07 ` Fabiano Rosas
2024-05-23 19:43 ` Peter Xu
2024-05-27 10:53 ` Markus Armbruster
2024-05-27 14:35 ` Peter Xu
2024-05-13 14:17 ` [PATCH 6/6] qerror: QERR_IO_ERROR is no longer used, drop Markus Armbruster
2024-05-13 14:28 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=236fa43a-bb2a-4d10-89a8-bc70bb9f406b@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).