From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Jamie Iles <jamie@nuviainc.com>, qemu-devel@nongnu.org
Cc: lmichel@kalray.eu
Subject: Re: [PATCH 1/2] hw/core/loader: return image sizes as ssize_t
Date: Thu, 11 Nov 2021 15:20:15 +0100 [thread overview]
Message-ID: <237570d9-028c-ccda-6eb5-d85f4433a3fc@redhat.com> (raw)
In-Reply-To: <20211111141141.3295094-2-jamie@nuviainc.com>
On 11/11/21 15:11, Jamie Iles wrote:
> Various loader functions return an int which limits images to 2GB which
> is fine for things like a BIOS/kernel image, but if we want to be able
> to load memory images or large ramdisks then any file over 2GB would
> silently fail to load.
>
> Cc: Luc Michel <lmichel@kalray.eu>
> Signed-off-by: Jamie Iles <jamie@nuviainc.com>
> ---
> hw/arm/armv7m.c | 2 +-
> hw/arm/boot.c | 8 ++--
> hw/core/generic-loader.c | 2 +-
> hw/core/loader.c | 81 +++++++++++++++++++++-------------------
> hw/i386/x86.c | 2 +-
> hw/riscv/boot.c | 5 ++-
> include/hw/loader.h | 55 +++++++++++++--------------
> 7 files changed, 80 insertions(+), 75 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-11-11 14:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 14:11 [PATCH 0/2] Fix integer overflows in loading of large images Jamie Iles
2021-11-11 14:11 ` [PATCH 1/2] hw/core/loader: return image sizes as ssize_t Jamie Iles
2021-11-11 14:20 ` Philippe Mathieu-Daudé [this message]
2021-11-12 8:25 ` Luc Michel
2021-11-15 4:24 ` Alistair Francis
2022-06-02 1:13 ` Alistair Francis
2021-11-11 14:11 ` [PATCH 2/2] hw/core/loader: workaround read() size limit Jamie Iles
2021-11-11 14:55 ` Philippe Mathieu-Daudé
2021-11-11 15:36 ` Jamie Iles
2021-11-11 15:43 ` Philippe Mathieu-Daudé
2021-11-11 15:55 ` Philippe Mathieu-Daudé
2021-11-11 17:04 ` Jamie Iles
2021-11-30 15:38 ` Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237570d9-028c-ccda-6eb5-d85f4433a3fc@redhat.com \
--to=philmd@redhat.com \
--cc=jamie@nuviainc.com \
--cc=lmichel@kalray.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).