From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Amit Shah <amit.shah@redhat.com>
Subject: [Qemu-devel] [PULL 5/7] scripts: set timeout when waiting for qemu monitor connection
Date: Fri, 22 Jul 2016 13:30:51 +0530 [thread overview]
Message-ID: <238064621fcf5fabedc36d2acdfffa72c723a748.1469174334.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1469174334.git.amit.shah@redhat.com>
In-Reply-To: <cover.1469174334.git.amit.shah@redhat.com>
From: "Daniel P. Berrange" <berrange@redhat.com>
If QEMU fails to launch for some reason, the QEMUMonitorProtocol
class accept() method will wait forever in a socket accept call.
Set a timeout of 15 seconds so that we fail more gracefully
instead of hanging the test script forever
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1469020993-29426-5-git-send-email-berrange@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
scripts/qmp/qmp.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py
index 70e927e..2d0d926 100644
--- a/scripts/qmp/qmp.py
+++ b/scripts/qmp/qmp.py
@@ -140,6 +140,7 @@ class QEMUMonitorProtocol:
@raise QMPConnectError if the greeting is not received
@raise QMPCapabilitiesError if fails to negotiate capabilities
"""
+ self.__sock.settimeout(15)
self.__sock, _ = self.__sock.accept()
self.__sockfile = self.__sock.makefile()
return self.__negotiate_capabilities()
--
2.7.4
next prev parent reply other threads:[~2016-07-22 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 8:00 [Qemu-devel] [PULL 0/7] migration: fix, perf testing framework Amit Shah
2016-07-22 8:00 ` [Qemu-devel] [PULL 1/7] migration: set state to post-migrate on failure Amit Shah
2016-07-22 8:00 ` [Qemu-devel] [PULL 2/7] scripts: add __init__.py file to scripts/qmp/ Amit Shah
2016-07-22 8:00 ` [Qemu-devel] [PULL 3/7] scripts: add a 'debug' parameter to QEMUMonitorProtocol Amit Shah
2016-07-22 8:00 ` [Qemu-devel] [PULL 4/7] scripts: refactor the VM class in iotests for reuse Amit Shah
2016-07-25 23:34 ` Max Reitz
2016-07-26 0:23 ` Max Reitz
2016-07-26 8:24 ` Daniel P. Berrange
2016-07-22 8:00 ` Amit Shah [this message]
2016-07-22 8:00 ` [Qemu-devel] [PULL 6/7] scripts: ensure monitor socket has SO_REUSEADDR set Amit Shah
2016-07-22 8:00 ` [Qemu-devel] [PULL 7/7] tests: introduce a framework for testing migration performance Amit Shah
2016-07-22 10:31 ` [Qemu-devel] [PULL 0/7] migration: fix, perf testing framework Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=238064621fcf5fabedc36d2acdfffa72c723a748.1469174334.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).