From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQVOi-0000aS-2h for qemu-devel@nongnu.org; Fri, 22 Jul 2016 04:01:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQVOd-0006iy-4T for qemu-devel@nongnu.org; Fri, 22 Jul 2016 04:01:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQVOc-0006ip-WB for qemu-devel@nongnu.org; Fri, 22 Jul 2016 04:01:23 -0400 From: Amit Shah Date: Fri, 22 Jul 2016 13:30:51 +0530 Message-Id: <238064621fcf5fabedc36d2acdfffa72c723a748.1469174334.git.amit.shah@redhat.com> In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PULL 5/7] scripts: set timeout when waiting for qemu monitor connection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Peter Maydell , Juan Quintela , "Dr. David Alan Gilbert" , "Daniel P. Berrange" , Amit Shah From: "Daniel P. Berrange" If QEMU fails to launch for some reason, the QEMUMonitorProtocol class accept() method will wait forever in a socket accept call. Set a timeout of 15 seconds so that we fail more gracefully instead of hanging the test script forever Signed-off-by: Daniel P. Berrange Message-Id: <1469020993-29426-5-git-send-email-berrange@redhat.com> Signed-off-by: Amit Shah --- scripts/qmp/qmp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py index 70e927e..2d0d926 100644 --- a/scripts/qmp/qmp.py +++ b/scripts/qmp/qmp.py @@ -140,6 +140,7 @@ class QEMUMonitorProtocol: @raise QMPConnectError if the greeting is not received @raise QMPCapabilitiesError if fails to negotiate capabilities """ + self.__sock.settimeout(15) self.__sock, _ = self.__sock.accept() self.__sockfile = self.__sock.makefile() return self.__negotiate_capabilities() -- 2.7.4