From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 10/12] qapi: document DisplayType enum
Date: Mon, 11 Feb 2019 12:28:12 -0600 [thread overview]
Message-ID: <2384878a-e9a2-ac4b-372d-9fdd493db5a1@redhat.com> (raw)
In-Reply-To: <CAJ+F1CKxmZdycF8q83ziSUB5Bnwk=NFASgfjJkEDsjuQ7vcSww@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On 2/9/19 7:15 AM, Marc-André Lureau wrote:
>>>> # Display (user interface) type.
>>>> #
>>>> +# @default: The default user interface.
>>>
>>> Any more hints on how this default is determined? Is it a compile-time
>>> decision, based on what libraries were linked in?
>>
>> Basically yes. A bit more complicated due to modules. gtk, sdl and
>> cocoa are checked, in that order. And if none of them is available the
>> vnc server is enabled.
>
>
> Eric, should I cram this comment there?: "(gtk, sdl and
> cocoa are checked, in that order. And if none of them is available the
> vnc server is enabled)"
If you think the end user will benefit from reading that, then it is
worth adding. Wordsmithing a bit:
@default: The default user interface, selecting from the first available
of gtk, sdl, cocoa, and vnc.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-11 18:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 14:15 [Qemu-devel] [PATCH v2 00/12] spice: add -display spice-app, setup and launch a Spice client Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 01/12] configure: bump spice-server required version to 0.12.5 Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 02/12] char/spice: trigger HUP event Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 03/12] char/spice: discard write() if backend is disconnected Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 04/12] spice: avoid spice runtime assert Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 05/12] spice: merge options lists Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 06/12] spice: do not stop spice if VM is paused Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 07/12] char: move SpiceChardev and open_spice_port() to spice.h header Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 08/12] char: register spice ports after spice started Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 09/12] build-sys: add gio-2.0 check Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 10/12] qapi: document DisplayType enum Marc-André Lureau
2018-12-20 14:46 ` Eric Blake
2019-01-07 9:45 ` Gerd Hoffmann
2019-02-09 13:15 ` Marc-André Lureau
2019-02-11 18:28 ` Eric Blake [this message]
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 11/12] spice: use a default name for the server Marc-André Lureau
2018-12-20 14:15 ` [Qemu-devel] [PATCH v2 12/12] display: add -display spice-app launching a Spice client Marc-André Lureau
2018-12-21 14:12 ` [Qemu-devel] [PATCH v2 00/12] spice: add -display spice-app, setup and launch " Victor Toso
2019-02-09 13:19 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2384878a-e9a2-ac4b-372d-9fdd493db5a1@redhat.com \
--to=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).