From: John Snow <jsnow@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] Dead code in cpu-models.h
Date: Tue, 19 Sep 2017 14:54:20 -0400 [thread overview]
Message-ID: <23878739-8df8-c2a4-2bf7-4c288cca56b8@redhat.com> (raw)
In-Reply-To: <853d5df6-a7a9-9284-ebbd-6282352879ba@redhat.com>
On 09/19/2017 04:14 AM, Thomas Huth wrote:
> On 19.09.2017 10:06, Paolo Bonzini wrote:
>> On 13/09/2017 21:08, John Snow wrote:
> [...]
>>> Farewell, bitrot code.
>>>
>>> Reviewed-by: John Snow <jsnow@redhat.com>
>>>
>>> Out of curiosity, I wonder ...
>>>
>>> jhuston@probe (foobar) ~/s/qemu> git grep '#if 0' | wc -l
>>> 320
>>
>> $ git grep -c '#if 0' | sort -k2 --field-separator=: -n
>> ...
>> hw/net/eepro100.c:21
>> target/ppc/cpu-models.h:76
>>
>> whoa :)
>
> Igor recently already removed the dead definitions from cpu-models.c :
>
> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=aef779605779579afbafff
>
> I guess we could now remove the corresponding dead definitions from the
> header, too...
>
> Any volunteers?
>
> Thomas
>
Well, I can just take a chainsaw to it blindly if you want to critique it.
next prev parent reply other threads:[~2017-09-19 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 10:21 [Qemu-devel] [PATCH] block: Clean up some bad code in the vvfat driver Thomas Huth
2017-09-13 13:57 ` Eric Blake
2017-09-13 19:08 ` [Qemu-devel] [Qemu-block] " John Snow
2017-09-19 8:06 ` Paolo Bonzini
2017-09-19 8:14 ` [Qemu-devel] Dead code in cpu-models.h (was: block: Clean up some bad code in the vvfat driver) Thomas Huth
2017-09-19 18:54 ` John Snow [this message]
2017-09-19 19:05 ` [Qemu-devel] Dead code in cpu-models.h Thomas Huth
2017-09-19 19:01 ` [Qemu-devel] [Qemu-block] [PATCH] block: Clean up some bad code in the vvfat driver John Snow
2017-09-19 19:08 ` Thomas Huth
2017-09-19 8:02 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23878739-8df8-c2a4-2bf7-4c288cca56b8@redhat.com \
--to=jsnow@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).