qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH for-10.1] CI: Use mingw-w64-x86_64-curl-winssl instead of mingw-w64-x86_64-curl for Windows build
Date: Mon, 18 Aug 2025 09:08:34 +0200	[thread overview]
Message-ID: <238d094b-105e-4efd-8209-ce35697a2ebb@redhat.com> (raw)
In-Reply-To: <cc8db062-a467-4b56-9ca7-c2da9890ec74@weilnetz.de>

On 18/08/2025 09.02, Stefan Weil wrote:
> Am 18.08.25 um 07:49 schrieb Thomas Huth:
>> I'll queue your patch for my next pull request ... just wondering: Did you 
>> run into any real issue here? AFAIK we're not running any related test on 
>> Windows in the CI, so there should not be any big difference?
> 
> Hi,
> 
> HTTPS connections don't work unless the server certificate can be validated. 
> Binaries with mingw-w64-x86_64-curl won't find the common CA certificates, 
> so server certificates cannot be validated and HTTPS connections fail. 
> With mingw-w64-x86_64-curl-winssl, the installed CA certificates from 
> Windows are used and HTTPS works fine.
> 
> The difference is therefore for any protocol which uses SSL.

Sure, but I was just wondering whether you observed a failure in a CI job. 
AFAIK we don't run any QEMU binary in that CI job, so the CI job itself 
should not hit the problem. And we don't publish the binaries as artifacts 
of the job either, so there's also no user that could run into this problem 
with the generated binaries there.

But anyway, it's better to fix it, in case someone uses the list in the yml 
file for their local installation to build QEMU, or in case we ever decide 
to publish the binaries from the CI job for consumption by the users.

  Thomas



  reply	other threads:[~2025-08-18  7:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <c4bcc116-bd15-4c86-9e7b-3bf33b31e792@weilnetz.de>
     [not found] ` <e2efea97-9cdb-4dac-bf9b-324e77a2817f@redhat.com>
2025-08-18  7:02   ` [PATCH for-10.1] CI: Use mingw-w64-x86_64-curl-winssl instead of mingw-w64-x86_64-curl for Windows build Stefan Weil via
2025-08-18  7:08     ` Thomas Huth [this message]
2025-08-06 20:09 Stefan Weil via
2025-08-06 20:27 ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=238d094b-105e-4efd-8209-ce35697a2ebb@redhat.com \
    --to=thuth@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).