[PATCH for-10.1] CI: Use mingw-w64-x86_64-curl-winssl instead of mingw-w64-x86_64-curl for Windows build

[PATCH for-10.1] CI: Use mingw-w64-x86_64-curl-winssl instead of mingw-w64-x86_64-curl for Windows build

[Stefan Weil via]

mingw-w64-x86_64-curl-winssl is required for https connections.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 .gitlab-ci.d/windows.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
index 45ed0c96fe..beac39e5bd 100644
--- a/.gitlab-ci.d/windows.yml
+++ b/.gitlab-ci.d/windows.yml
@@ -77,7 +77,7 @@ msys2-64bit:
       git grep make sed
       mingw-w64-x86_64-binutils
       mingw-w64-x86_64-ccache
-      mingw-w64-x86_64-curl
+      mingw-w64-x86_64-curl-winssl
       mingw-w64-x86_64-gcc
       mingw-w64-x86_64-glib2
       mingw-w64-x86_64-libnfs
-- 
2.47.2

Re: [PATCH for-10.1] CI: Use mingw-w64-x86_64-curl-winssl instead of mingw-w64-x86_64-curl for Windows build

[Pierrick Bouvier]

On 8/6/25 1:09 PM, Stefan Weil via wrote:
> mingw-w64-x86_64-curl-winssl is required for https connections.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>   .gitlab-ci.d/windows.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
> index 45ed0c96fe..beac39e5bd 100644
> --- a/.gitlab-ci.d/windows.yml
> +++ b/.gitlab-ci.d/windows.yml
> @@ -77,7 +77,7 @@ msys2-64bit:
>         git grep make sed
>         mingw-w64-x86_64-binutils
>         mingw-w64-x86_64-ccache
> -      mingw-w64-x86_64-curl
> +      mingw-w64-x86_64-curl-winssl
>         mingw-w64-x86_64-gcc
>         mingw-w64-x86_64-glib2
>         mingw-w64-x86_64-libnfs

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Re: [PATCH for-10.1] CI: Use mingw-w64-x86_64-curl-winssl instead of mingw-w64-x86_64-curl for Windows build

[Stefan Weil via]

Am 18.08.25 um 07:49 schrieb Thomas Huth:
> I'll queue your patch for my next pull request ... just wondering: Did 
> you run into any real issue here? AFAIK we're not running any related 
> test on Windows in the CI, so there should not be any big difference?

Hi,

HTTPS connections don't work unless the server certificate can be 
validated. Binaries with mingw-w64-x86_64-curl won't find the common CA 
certificates, so server certificates cannot be validated and HTTPS 
connections fail. With mingw-w64-x86_64-curl-winssl, the installed CA 
certificates from Windows are used and HTTPS works fine.

The difference is therefore for any protocol which uses SSL. I assume 
that there is no difference for other protocols which are supported by 
curl, but did not test this.

Stefan

Re: [PATCH for-10.1] CI: Use mingw-w64-x86_64-curl-winssl instead of mingw-w64-x86_64-curl for Windows build

[Thomas Huth]

On 18/08/2025 09.02, Stefan Weil wrote:
> Am 18.08.25 um 07:49 schrieb Thomas Huth:
>> I'll queue your patch for my next pull request ... just wondering: Did you 
>> run into any real issue here? AFAIK we're not running any related test on 
>> Windows in the CI, so there should not be any big difference?
> 
> Hi,
> 
> HTTPS connections don't work unless the server certificate can be validated. 
> Binaries with mingw-w64-x86_64-curl won't find the common CA certificates, 
> so server certificates cannot be validated and HTTPS connections fail. 
> With mingw-w64-x86_64-curl-winssl, the installed CA certificates from 
> Windows are used and HTTPS works fine.
> 
> The difference is therefore for any protocol which uses SSL.

Sure, but I was just wondering whether you observed a failure in a CI job. 
AFAIK we don't run any QEMU binary in that CI job, so the CI job itself 
should not hit the problem. And we don't publish the binaries as artifacts 
of the job either, so there's also no user that could run into this problem 
with the generated binaries there.

But anyway, it's better to fix it, in case someone uses the list in the yml 
file for their local installation to build QEMU, or in case we ever decide 
to publish the binaries from the CI job for consumption by the users.

  Thomas