From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Peter Krempa" <pkrempa@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [libvirt] [PATCH] virtio-blk: deprecate SCSI passthrough
Date: Fri, 13 Dec 2019 16:25:45 +0100 [thread overview]
Message-ID: <239982df-8527-2d13-710e-d3c14c9a22ab@redhat.com> (raw)
In-Reply-To: <20191213151009.GF2232389@redhat.com>
On 13/12/19 16:10, Daniel P. Berrangé wrote:
> I don't think it really matters. QEMU is deprecating it with no
> seemless direct replacement, so I don't think libvirt needs to
> be concerned. The feature simply becomes unsupported.
>
> At the very most we need to check if it exists before using it,
> but even that's just a nice to have which results in a slightly
> prettier error message.
Libvirt right now assumes that a QEMU without the scsi property defaults
to "on", but if the oldest supported QEMU version is 1.5.3 then it
already has the property. So you can just give an error if there is no
scsi property and device='lun'.
Paolo
next prev parent reply other threads:[~2019-12-13 21:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 14:46 [PATCH] virtio-blk: deprecate SCSI passthrough Stefan Hajnoczi
2019-12-13 14:56 ` Paolo Bonzini
2019-12-13 15:07 ` [libvirt] " Peter Krempa
2019-12-13 15:10 ` Daniel P. Berrangé
2019-12-13 15:25 ` Paolo Bonzini [this message]
2019-12-13 14:56 ` Christoph Hellwig
2019-12-14 12:21 ` Thomas Huth
2019-12-17 10:38 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=239982df-8527-2d13-710e-d3c14c9a22ab@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).