From: "Ripke, Klaus" <klaus.ripke@secunet.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"philmd@linaro.org" <philmd@linaro.org>
Cc: "kraxel@redhat.com" <kraxel@redhat.com>,
"marcandre.lureau@gmail.com" <marcandre.lureau@gmail.com>
Subject: Re: [PATCH] usb-ccid: make ids and descriptor configurable
Date: Tue, 17 Jan 2023 13:29:18 +0000 [thread overview]
Message-ID: <23b908a3a9923f943e82246d0fcaa1f02d6928cd.camel@secunet.com> (raw)
In-Reply-To: <cff14816-39eb-db1c-9bda-51cad7fcb7c1@linaro.org>
hi Philippe,
On Tue, 2023-01-17 at 08:04 +0100, Philippe Mathieu-Daudé wrote:
> If you create 2 devices with different properties, the
> first gets its properties overwritten with the second's
> ones.
The !initialized guard should prevent that.
In practize you would not create more usb-ccid devices,
but usb-ccid-passthru on the same class,
slots are now supported in card_realize.
Abandoning all the static structures seems too big a change
for a little tweaking, and setting from ENV was refused.
> > + qemu_ccid_descriptor[DESC_FEAT2] = s->feat2;
Some devices (libcacard vscclient) want 4 here for "Automatic IFSD
exchange".
best Klaus
--
Klaus Ripke
Senior Developer
Public Authorities Division
secunet Security Networks AG
Telefon: +49 201 5454-2982
next prev parent reply other threads:[~2023-01-17 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 15:46 [PATCH] usb-ccid: make ids and descriptor configurable Ripke, Klaus
2023-01-17 7:04 ` Philippe Mathieu-Daudé
2023-01-17 13:29 ` Ripke, Klaus [this message]
2023-01-23 16:25 ` Ripke, Klaus
2023-03-01 21:37 ` seeking advice for configuring usb_desc in ccid / dev-smartcard-reader.c Ripke, Klaus
-- strict thread matches above, loose matches on Subject: below --
2023-01-10 13:18 [PATCH] usb-ccid: make ids and descriptor configurable Ripke, Klaus
2023-01-11 8:09 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23b908a3a9923f943e82246d0fcaa1f02d6928cd.camel@secunet.com \
--to=klaus.ripke@secunet.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).