From: "Bill C. Riemers" <docbill@freeshell.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC][PATCH] make sure disk writes actually hit disk
Date: Sat, 29 Jul 2006 13:33:01 -0400 [thread overview]
Message-ID: <23bcb8700607291033q7ce66872j2ce2d830a8578dbc@mail.gmail.com> (raw)
In-Reply-To: <44CB77DF.9030700@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]
How about compromising, and making the patch a run time option. Presumably
this is only a problem when the virtual machine is not properly shutdown.
For those ho want the extra security of knowing the data will be written
regardless of the shutdown status they can enable the flag. By default it
could be turned off. Then everybody can be happy.
Bill
On 7/29/06, Rik van Riel <riel@redhat.com> wrote:
>
> Fabrice Bellard wrote:
> > Hi,
> >
> > Using O_SYNC for disk image access is not acceptable: QEMU relies on the
> > host OS to ensure that the data is written correctly.
>
> This means that write ordering is not preserved, and on a power
> failure any data written by qemu (or Xen fully virt) guests may
> not be preserved.
>
> Applications running on the host can count on fsync doing the
> right thing, meaning that if they call fsync, the data *will*
> have made it to disk. Applications running inside a guest have
> no guarantees that their data is actually going to make it
> anywhere when fsync returns...
>
> This may look like hair splitting, but so far I've lost a
> (test) postgresql database to this 3 times already. Not getting
> the guest application's data to disk when the application calls
> fsync is a recipe for disaster.
>
> --
> "Debugging is twice as hard as writing the code in the first place.
> Therefore, if you write the code as cleverly as possible, you are,
> by definition, not smart enough to debug it." - Brian W. Kernighan
>
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
[-- Attachment #2: Type: text/html, Size: 2121 bytes --]
next prev parent reply other threads:[~2006-07-29 17:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 19:54 [Qemu-devel] [RFC][PATCH] make sure disk writes actually hit disk Rik van Riel
2006-07-28 19:58 ` [Qemu-devel] " Rik van Riel
2006-07-28 20:12 ` Anthony Liguori
2006-07-28 20:18 ` Rik van Riel
2006-07-28 20:30 ` Paul Brook
2006-07-28 20:43 ` Rik van Riel
2006-07-28 21:01 ` Paul Brook
2006-07-31 7:08 ` Jens Axboe
2006-07-29 9:57 ` [Qemu-devel] " Fabrice Bellard
2006-07-29 14:59 ` Rik van Riel
2006-07-29 16:04 ` Paul Brook
2006-07-29 16:22 ` Rik van Riel
2006-07-29 16:31 ` Paul Brook
2006-07-31 7:08 ` Jens Axboe
2006-07-29 17:33 ` Bill C. Riemers [this message]
2006-07-30 21:47 ` Jamie Lokier
2006-07-30 21:41 ` Jamie Lokier
2006-07-31 9:52 ` andrzej zaborowski
2006-07-31 10:17 ` Jens Axboe
2006-07-31 17:50 ` andrzej zaborowski
2006-07-31 7:08 ` Jens Axboe
2006-07-31 7:56 ` Jonas Maebe
2006-07-31 8:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23bcb8700607291033q7ce66872j2ce2d830a8578dbc@mail.gmail.com \
--to=docbill@freeshell.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).