From: Liam Merwick <liam.merwick@oracle.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: remove unnecessary assignments from Makefile.target
Date: Fri, 15 Feb 2019 14:07:50 +0000 [thread overview]
Message-ID: <23c50a32-dbe3-db22-fec5-f0fd9acf11dc@oracle.com> (raw)
In-Reply-To: <1550227757-10869-2-git-send-email-pbonzini@redhat.com>
On 15/02/2019 10:49, Paolo Bonzini wrote:
> It is only necessary to clear block-obj-y because Makefile.objs
> uses "+=" instead of "="; fix that and remove the assignment.
> The other variables need not be cleared at all.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
> ---
> Makefile.objs | 2 +-
> Makefile.target | 4 ----
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index c3a2354..e5cc928 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -22,7 +22,7 @@ slirp-obj-$(CONFIG_SLIRP) = slirp/
> #######################################################################
> # block-obj-y is code used by both qemu system emulation and qemu-img
>
> -block-obj-y += nbd/
> +block-obj-y = nbd/
> block-obj-y += block.o blockjob.o job.o
> block-obj-y += block/ scsi/
> block-obj-y += qemu-io-cmds.o
> diff --git a/Makefile.target b/Makefile.target
> index a56a72f..06b44c0 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -174,10 +174,6 @@ endif # CONFIG_SOFTMMU
> dummy := $(call unnest-vars,,obj-y)
> all-obj-y := $(obj-y)
>
> -block-obj-y :=
> -common-obj-y :=
> -chardev-obj-y :=
> -slirp-obj-y :=
> include $(SRC_PATH)/Makefile.objs
> dummy := $(call unnest-vars,.., \
> block-obj-y \
>
next prev parent reply other threads:[~2019-02-15 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 10:49 [Qemu-devel] [PATCH] build: remove unnecessary assignments from Makefile.target Paolo Bonzini
2019-02-15 14:07 ` Liam Merwick [this message]
2019-02-18 9:55 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23c50a32-dbe3-db22-fec5-f0fd9acf11dc@oracle.com \
--to=liam.merwick@oracle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).