From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7684AC433EF for ; Wed, 10 Nov 2021 09:51:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 199CA61105 for ; Wed, 10 Nov 2021 09:51:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 199CA61105 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:60152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkkFz-0004Th-2p for qemu-devel@archiver.kernel.org; Wed, 10 Nov 2021 04:51:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkkEO-00036A-HW for qemu-devel@nongnu.org; Wed, 10 Nov 2021 04:49:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkkEI-0007H3-Qj for qemu-devel@nongnu.org; Wed, 10 Nov 2021 04:49:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636537747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eo8Tfa3Rc5y1D8JUe4z6OZdsUyWfqR+nAiLKnhAI2iU=; b=I+URcC1YNnWy9R3oDOd9wwmT7GdASaYevsskQzQnpaQjod9fe8nsU6qns3tD2HJ4dTZncB TLs0WQrWqm62610ZzyPERrW5NJWdheSVonU3gz5EX/OnWF9XjzDPdPsLjjxBiP4erjCHD0 Xiq2VPQokc0Ea+GREGiCtWC2UZLLrmY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-kDUPnccUPbGsBgsA2dJdtg-1; Wed, 10 Nov 2021 04:49:01 -0500 X-MC-Unique: kDUPnccUPbGsBgsA2dJdtg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E806C1F764; Wed, 10 Nov 2021 09:49:00 +0000 (UTC) Received: from [10.33.192.183] (dhcp-192-183.str.redhat.com [10.33.192.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4BC9B5C1C5; Wed, 10 Nov 2021 09:49:00 +0000 (UTC) Message-ID: <23c75589-50a8-5808-dd81-b5045f11e095@redhat.com> Date: Wed, 10 Nov 2021 10:48:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] meson: remove useless libdl test To: Paolo Bonzini , qemu-devel@nongnu.org References: <20211110092454.30916-1-pbonzini@redhat.com> From: Thomas Huth In-Reply-To: <20211110092454.30916-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.678, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/11/2021 10.24, Paolo Bonzini wrote: > dlopen is never used after it is sought via cc.find_library, because > plugins use gmodule instead; remove the test. > > Signed-off-by: Paolo Bonzini > --- > accel/tcg/meson.build | 2 +- > meson.build | 8 +------- > 2 files changed, 2 insertions(+), 8 deletions(-) Right. I've just grep'ed for "dlopen" or the related dlfcn.h header in the sources and did not see any direct use. Reviewed-by: Thomas Huth