From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Hawkins Jiawei <yin31149@gmail.com>,
jasowang@redhat.com, mst@redhat.com, eperezma@redhat.com
Cc: qemu-devel@nongnu.org, 18801353760@163.com,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH v2 2/2] vdpa: order vdpa_feature_bits array
Date: Fri, 30 Jun 2023 12:20:26 +0200 [thread overview]
Message-ID: <23c90163-657e-3d4b-0c74-437650a3e282@linaro.org> (raw)
In-Reply-To: <b31f0bce96ad1b66fabeace182cddb41fede9683.1688112025.git.yin31149@gmail.com>
On 30/6/23 10:54, Hawkins Jiawei wrote:
> This patch reorganizes the vdpa_feature_bits array
> in ascending order based on its value to avoid future duplicates.
>
> Signed-off-by: Hawkins Jiawei <yin31149@gmail.com>
> ---
> v2:
> - resolve conflicts with the master branch
>
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-06/msg01585.html
>
> net/vhost-vdpa.c | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 0479988a79..db7f1241af 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -50,15 +50,12 @@ typedef struct VhostVDPAState {
> bool started;
> } VhostVDPAState;
>
> +/* The array is sorted in ascending order based on its value */
Alphabetically would have been simpler IMO, anyhow:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-06-30 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 8:54 [PATCH v2 0/2] vdpa: refactor vdpa_feature_bits array Hawkins Jiawei
2023-06-30 8:54 ` [PATCH v2 1/2] vdpa: delete duplicated VIRTIO_NET_F_RSS in vdpa_feature_bits Hawkins Jiawei
2023-06-30 10:19 ` Philippe Mathieu-Daudé
2023-06-30 8:54 ` [PATCH v2 2/2] vdpa: order vdpa_feature_bits array Hawkins Jiawei
2023-06-30 10:20 ` Philippe Mathieu-Daudé [this message]
2023-06-30 12:18 ` Hawkins Jiawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23c90163-657e-3d4b-0c74-437650a3e282@linaro.org \
--to=philmd@linaro.org \
--cc=18801353760@163.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=yin31149@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).