From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com
Subject: Re: [PATCH 2/3] user: move common-user includes to a subdirectory of {bsd,linux}-user/
Date: Tue, 21 Dec 2021 12:32:30 -0800 [thread overview]
Message-ID: <23cf60a2-0ac0-90ec-fbc1-4b396e50f708@linaro.org> (raw)
In-Reply-To: <20211221163300.453146-3-pbonzini@redhat.com>
On 12/21/21 8:32 AM, Paolo Bonzini wrote:
> Avoid polluting the compilation of common-user/ with local include files;
> making an include file available to common-user/ should be a deliberate
> decision in order to keep a clear interface that can be used by both
> bsd-user/ and linux-user/.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> bsd-user/{ => include}/special-errno.h | 0
> bsd-user/meson.build | 2 +-
> linux-user/{ => include}/host/aarch64/host-signal.h | 0
> linux-user/{ => include}/host/alpha/host-signal.h | 0
> linux-user/{ => include}/host/arm/host-signal.h | 0
> linux-user/{ => include}/host/i386/host-signal.h | 0
> linux-user/{ => include}/host/mips/host-signal.h | 0
> linux-user/{ => include}/host/ppc/host-signal.h | 0
> linux-user/{ => include}/host/ppc64/host-signal.h | 0
> linux-user/{ => include}/host/riscv/host-signal.h | 0
> linux-user/{ => include}/host/s390/host-signal.h | 0
> linux-user/{ => include}/host/s390x/host-signal.h | 0
> linux-user/{ => include}/host/sparc/host-signal.h | 0
> linux-user/{ => include}/host/sparc64/host-signal.h | 0
> linux-user/{ => include}/host/x32/host-signal.h | 0
> linux-user/{ => include}/host/x86_64/host-signal.h | 0
> linux-user/{ => include}/special-errno.h | 0
> linux-user/meson.build | 4 ++--
> 18 files changed, 3 insertions(+), 3 deletions(-)
> rename bsd-user/{ => include}/special-errno.h (100%)
> rename linux-user/{ => include}/host/aarch64/host-signal.h (100%)
> rename linux-user/{ => include}/host/alpha/host-signal.h (100%)
> rename linux-user/{ => include}/host/arm/host-signal.h (100%)
> rename linux-user/{ => include}/host/i386/host-signal.h (100%)
> rename linux-user/{ => include}/host/mips/host-signal.h (100%)
> rename linux-user/{ => include}/host/ppc/host-signal.h (100%)
> rename linux-user/{ => include}/host/ppc64/host-signal.h (100%)
> rename linux-user/{ => include}/host/riscv/host-signal.h (100%)
> rename linux-user/{ => include}/host/s390/host-signal.h (100%)
> rename linux-user/{ => include}/host/s390x/host-signal.h (100%)
> rename linux-user/{ => include}/host/sparc/host-signal.h (100%)
> rename linux-user/{ => include}/host/sparc64/host-signal.h (100%)
> rename linux-user/{ => include}/host/x32/host-signal.h (100%)
> rename linux-user/{ => include}/host/x86_64/host-signal.h (100%)
> rename linux-user/{ => include}/special-errno.h (100%)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-12-21 20:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 16:32 [PATCH 0/3] build: some cleanups for common-user/ infrastructure Paolo Bonzini
2021-12-21 16:32 ` [PATCH 1/3] meson: reuse common_user_inc when building files specific to user-mode emulators Paolo Bonzini
2021-12-21 20:33 ` Richard Henderson
2021-12-21 16:32 ` [PATCH 2/3] user: move common-user includes to a subdirectory of {bsd, linux}-user/ Paolo Bonzini
2021-12-21 19:56 ` [PATCH 2/3] user: move common-user includes to a subdirectory of {bsd,linux}-user/ Richard Henderson
2021-12-21 19:57 ` Richard Henderson
2021-12-21 20:32 ` Richard Henderson [this message]
2021-12-21 16:33 ` [PATCH 3/3] meson: cleanup common-user/ build Paolo Bonzini
2021-12-21 20:31 ` Richard Henderson
2021-12-22 22:05 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23cf60a2-0ac0-90ec-fbc1-4b396e50f708@linaro.org \
--to=richard.henderson@linaro.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).