* [PATCH] configure: fix GLIB_VERSION for cross-compilation
@ 2023-01-07 13:32 Paolo Bonzini
2023-01-07 15:33 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2023-01-07 13:32 UTC (permalink / raw)
To: qemu-devel
Cc: Валентин,
qemu-stable
configure uses "pkg-config" directly so that GLIB_VERSION is always based
on host glib version. To correctly handle cross-compilation it should use
"$pkg_config" and take GLIB_VERSION from the cross-compiled glib.
Reported-by: Валентин <val15032008@mail.ru>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1414
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 22818926576c..6f5e77a71361 100755
--- a/configure
+++ b/configure
@@ -2375,7 +2375,7 @@ echo "QEMU_OBJCFLAGS=$QEMU_OBJCFLAGS" >> $config_host_mak
echo "GLIB_CFLAGS=$glib_cflags" >> $config_host_mak
echo "GLIB_LIBS=$glib_libs" >> $config_host_mak
echo "GLIB_BINDIR=$glib_bindir" >> $config_host_mak
-echo "GLIB_VERSION=$(pkg-config --modversion glib-2.0)" >> $config_host_mak
+echo "GLIB_VERSION=$($pkg_config --modversion glib-2.0)" >> $config_host_mak
echo "QEMU_LDFLAGS=$QEMU_LDFLAGS" >> $config_host_mak
echo "EXESUF=$EXESUF" >> $config_host_mak
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configure: fix GLIB_VERSION for cross-compilation
2023-01-07 13:32 [PATCH] configure: fix GLIB_VERSION for cross-compilation Paolo Bonzini
@ 2023-01-07 15:33 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-07 15:33 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
Cc: Валентин,
qemu-stable
On 7/1/23 14:32, Paolo Bonzini wrote:
> configure uses "pkg-config" directly so that GLIB_VERSION is always based
> on host glib version. To correctly handle cross-compilation it should use
> "$pkg_config" and take GLIB_VERSION from the cross-compiled glib.
>
> Reported-by: Валентин <val15032008@mail.ru>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1414
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-07 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-07 13:32 [PATCH] configure: fix GLIB_VERSION for cross-compilation Paolo Bonzini
2023-01-07 15:33 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).